Differential D6691

common/archive: Add lookup_origin_snapshots function
ClosedPublic
Actions

Authored by anlambert on Nov 25 2021, 4:01 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T3631: Make snapshot query parameter mandatory when browsing objects in an origin context

Commits

rDWAPPSd7f3a3a4f8ce: common/archive: Add lookup_origin_snapshots function

Summary

This wraps the call to origin_snapshot_get_all method from the
storage interface.

Related to T3631

Diff Detail

Repository

rDWAPPS Web applications

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 25175
Build 39334: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 39333: arc lint + arc unit

Event Timeline

anlambert created this revision.Nov 25 2021, 4:01 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 25 2021, 4:01 PM

Build is green

Patch application report for D6691 (id=24305)

Rebasing onto 20a9d18559...

Current branch diff-target is up to date.

Changes applied before test

commit c91fc8e02848ff3852d0bc76dfa0963157eff9d9
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Nov 25 16:00:39 2021 +0100

    common/archive: Add lookup_origin_snapshots function
    
    This wraps the call to origin_snapshot_get_all method from the
    storage interface.
    
    Related to T3631

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1245/ for more details.

Harbormaster completed remote builds in B25175: Diff 24305.Nov 25 2021, 4:19 PM

anlambert requested review of this revision.Nov 25 2021, 4:19 PM

Where is it called from?

In D6691#174048, @vlorentz wrote:

Where is it called from?

I will use it in a future diff to check if a snapshot is associated to an origin.

vlorentz accepted this revision.Nov 29 2021, 10:55 AM

vlorentz added inline comments.

swh/web/common/archive.py
299

This revision is now accepted and ready to land.Nov 29 2021, 10:55 AM

Update docstring

Build is green

Patch application report for D6691 (id=24341)

Rebasing onto 806623eb53...

First, rewinding head to replay your work on top of it...
Applying: common/archive: Add lookup_origin_snapshots function

Changes applied before test

commit 26ae6c0ad2acfdbe214eae3b212b03640b5e5663
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Nov 25 16:00:39 2021 +0100

    common/archive: Add lookup_origin_snapshots function
    
    This wraps the call to origin_snapshot_get_all method from the
    storage interface.
    
    Related to T3631

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1249/ for more details.

Harbormaster completed remote builds in B25215: Diff 24341.Nov 29 2021, 11:22 AM

Rebase

This revision was landed with ongoing or failed builds.Nov 29 2021, 11:48 AM

Closed by commit rDWAPPSd7f3a3a4f8ce: common/archive: Add lookup_origin_snapshots function (authored by anlambert). · Explain Why

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPSd7f3a3a4f8ce: common/archive: Add lookup_origin_snapshots function.

Build was aborted

Patch application report for D6691 (id=24343)

Rebasing onto 806623eb53...

Current branch diff-target is up to date.

Changes applied before test

commit d7f3a3a4f8ce9b55f1b06aeea92b883126a2915d
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Nov 25 16:00:39 2021 +0100

    common/archive: Add lookup_origin_snapshots function
    
    This wraps the call to origin_snapshot_get_all method from the
    storage interface.
    
    Related to T3631

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1250/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1250/console

Harbormaster failed remote builds in B25217: Diff 24343!Nov 29 2021, 11:53 AM