misc/iframe: Fix archive link when there is no snapshot context
ClosedPublic
Actions

Authored by anlambert on Nov 24 2021, 11:40 AM.

Details

Reviewers

moranegg

Group Reviewers

Reviewers

Commits

rDWAPPS20a9d1855929: misc/iframe: Fix archive link when there is no snapshot context

Summary

When the input SWHID to browse in an iframe does not have any snapshot
related qualifiers, the generated link to browse the object in the
main archive website was invalid and was leading to HTTP errors.

For instance, in that directory view, clicking on the View in the archive link leads to a 404 error.

Diff Detail

Repository

rDWAPPS Web applications

Branch

iframe-archive-link-no-snapshot-context-fix

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 25148
Build 39299: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 39298: arc lint + arc unit

Event Timeline

anlambert created this revision.Nov 24 2021, 11:40 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 24 2021, 11:40 AM

anlambert edited the summary of this revision. (Show Details)Nov 24 2021, 11:40 AM

Build has FAILED

Patch application report for D6681 (id=24273)

Rebasing onto 2a646e0e19...

Current branch diff-target is up to date.

Changes applied before test

commit 20a9d185592917d1092a86df295352ef2d000957
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Nov 24 11:35:10 2021 +0100

    misc/iframe: Fix archive link when there is no snapshot context
    
    When the input SWHID to browse in an iframe does not have any snapshot
    related qualifiers, the generated link to browse the object in the
    main archive website was invalid and was leading to HTTP errors.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1243/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1243/console

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 24 2021, 11:59 AM

Harbormaster failed remote builds in B25148: Diff 24273!

Build is green

Patch application report for D6681 (id=24273)

Rebasing onto 2a646e0e19...

Current branch diff-target is up to date.

Changes applied before test

commit 20a9d185592917d1092a86df295352ef2d000957
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Nov 24 11:35:10 2021 +0100

    misc/iframe: Fix archive link when there is no snapshot context
    
    When the input SWHID to browse in an iframe does not have any snapshot
    related qualifiers, the generated link to browse the object in the
    main archive website was invalid and was leading to HTTP errors.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1244/ for more details.

Harbormaster completed remote builds in B25148: Diff 24273.Nov 24 2021, 12:17 PM

anlambert requested review of this revision.Nov 24 2021, 12:17 PM

moranegg accepted this revision.Nov 24 2021, 3:05 PM

This revision is now accepted and ready to land.Nov 24 2021, 3:05 PM

Closed by commit rDWAPPS20a9d1855929: misc/iframe: Fix archive link when there is no snapshot context (authored by anlambert). · Explain WhyNov 24 2021, 3:35 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS20a9d1855929: misc/iframe: Fix archive link when there is no snapshot context.