Page MenuHomeSoftware Heritage

rlog: fix parsing of multiple file revisions
ClosedPublic

Authored by stsp on Oct 27 2021, 12:26 PM.

Details

Summary

The rlog parser was only fetching a single file revision because
some lines of code had the wrong indentation. These lines were
supposed to be part of a loop body but were only executed once.

Also rename a function which had a misleading name and docstring.
This function does in fact process the entire RCS revision history
of a given file, as opposed to just one entry of RCS revision history.

Found while testing ingestion of the GNU dino repository from
cvs.savannah.gnu.org/sources/dino

Diff Detail

Repository
rDLDCVS CVS Loader
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24717
Build 38580: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 38579: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D6560 (id=23834)

Rebasing onto 7f761b8550...

Current branch diff-target is up to date.
Changes applied before test
commit a09530518522e9ff59b28d42164f721f5686c7b6
Author: Stefan Sperling <stsp@stsp.name>
Date:   Wed Oct 27 12:15:10 2021 +0200

    rlog: fix parsing of multiple file revisions
    
    The rlog parser was only fetching a single file revision because
    some lines of code had the wrong indentation. These lines were
    supposed to be part of a loop body but were only executed once.
    
    Also rename a function which had a misleading name and docstring.
    This function does in fact process the entire RCS revision history
    of a given file, as opposed to just one entry of RCS revision history.
    
    Found while testing ingestion of the GNU dino repository from
    cvs.savannah.gnu.org/sources/dino

See https://jenkins.softwareheritage.org/job/DLDCVS/job/tests-on-diff/35/ for more details.

stsp requested review of this revision.Oct 27 2021, 12:28 PM
This revision is now accepted and ready to land.Oct 27 2021, 1:48 PM
This revision was landed with ongoing or failed builds.Oct 27 2021, 3:59 PM
This revision was automatically updated to reflect the committed changes.

Build is green

Patch application report for D6560 (id=23852)

Rebasing onto 6ff0b4473c...

Current branch diff-target is up to date.
Changes applied before test
commit 0829dc3309d784c394c17e90bea1760e3d30223e
Author: Stefan Sperling <stsp@stsp.name>
Date:   Wed Oct 27 12:15:10 2021 +0200

    rlog: fix parsing of multiple file revisions
    
    The rlog parser was only fetching a single file revision because
    some lines of code had the wrong indentation. These lines were
    supposed to be part of a loop body but were only executed once.
    
    Also rename a function which had a misleading name and docstring.
    This function does in fact process the entire RCS revision history
    of a given file, as opposed to just one entry of RCS revision history.
    
    Found while testing ingestion of the GNU dino repository from
    cvs.savannah.gnu.org/sources/dino

See https://jenkins.softwareheritage.org/job/DLDCVS/job/tests-on-diff/39/ for more details.