Differential D6536

Restrict the click version to avoid conflict version with celery's
ClosedPublic
Actions

Authored by ardumont on Oct 22 2021, 10:52 AM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDSCHecc0e2803e0b: Restrict the click version to avoid conflict version with celery's

Summary

Otherwise, in some use cases, like run in docker, the install fails on
conflicted version. Ended up in refusing to start the container.

Related to P1205#8092

Test Plan

tox still happy

Diff Detail

Repository

rDSCH Scheduling utilities

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 24645
Build 38464: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 38463: arc lint + arc unit

Event Timeline

ardumont created this revision.Oct 22 2021, 10:52 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 22 2021, 10:52 AM

Build is green

Patch application report for D6536 (id=23758)

Rebasing onto 243a69fc35...

Current branch diff-target is up to date.

Changes applied before test

commit 11e836f48053976a29d28ea1a325feaee721c558
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 22 10:44:08 2021 +0200

    Restrict the click version to avoid conflict version with celery's
    
    Otherwise, in some edge case, like run in docker, the install fails on conflict.
    
    Related to P1205#8092

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/474/ for more details.

Harbormaster completed remote builds in B24644: Diff 23758.Oct 22 2021, 10:54 AM

ardumont requested review of this revision.Oct 22 2021, 10:54 AM

Looks good to me, I can also reproduce the issues after click upgrade to 8.x.

requirements.txt
8	missing space after <

This revision is now accepted and ready to land.Oct 22 2021, 11:13 AM

Adapt

Build is green

Patch application report for D6536 (id=23759)

Rebasing onto 243a69fc35...

Current branch diff-target is up to date.

Changes applied before test

commit ecc0e2803e0b2e63c02c0ec4fd0b3377f7fabc7d
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 22 10:44:08 2021 +0200

    Restrict the click version to avoid conflict version with celery's
    
    Otherwise, in some edge case, like run in docker, the install fails on conflict.
    
    Related to P1205#8092

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/475/ for more details.

Harbormaster completed remote builds in B24645: Diff 23759.Oct 22 2021, 11:24 AM

Closed by commit rDSCHecc0e2803e0b: Restrict the click version to avoid conflict version with celery's (authored by ardumont). · Explain WhyOct 22 2021, 11:34 AM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDSCHecc0e2803e0b: Restrict the click version to avoid conflict version with celery's.

anlambert mentioned this in D6537: Dockerfile: Avoid pip 21.3 version preventing working container override.Oct 22 2021, 11:41 AM