Differential D6374

query_language/tokens.js: Add new visit types
ClosedPublic
Actions

Authored by anlambert on Sep 29 2021, 3:17 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T3424: Opam support

Commits

rDSEAf8385df40249: query_language/tokens.js: Add new visit types

Summary

New visit types are or will be available in production so we
must add them here or we will have an error when searching
such origins.

Related sentry issue

Related to T3424

Diff Detail

Repository

rDSEA Archive search

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 24095
Build 37592: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 37591: arc lint + arc unit

Event Timeline

anlambert created this revision.Sep 29 2021, 3:17 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 29 2021, 3:17 PM

Build is green

Patch application report for D6374 (id=23179)

Rebasing onto 8176f2e67e...

Current branch diff-target is up to date.

Changes applied before test

commit b0b7bdd69b0454e1715cb7e2cf6b6acc93e0d649
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Sep 29 15:16:31 2021 +0200

    query_language/tokens.js: Add opam visit type
    
    A new visit type is available in production so we must add it here
    or we will have an error when searching such origins.

See https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/295/ for more details.

Harbormaster completed remote builds in B24095: Diff 23179.Sep 29 2021, 3:21 PM

anlambert requested review of this revision.Sep 29 2021, 3:21 PM

anlambert edited the summary of this revision. (Show Details)Sep 29 2021, 3:27 PM

anlambert added a task: T3424: Opam support.

anlambert mentioned this in D6375: misc/coverage: Add opam to listed origins.Sep 29 2021, 3:34 PM

ok for me.

Don't we want to add bzr and cvs immediately though?

This revision is now accepted and ready to land.Sep 29 2021, 3:38 PM

In D6374#165396, @ardumont wrote:

ok for me.

Don't we want to add bzr and cvs immediately though?

Indeed, it makes sense, will update before landing.

Update: Also add bzr and cvs visit types.

anlambert retitled this revision from query_language/tokens.js: Add opam visit type to query_language/tokens.js: Add new visit types.Sep 29 2021, 3:43 PM

anlambert edited the summary of this revision. (Show Details)

Build is green

Patch application report for D6374 (id=23188)

Rebasing onto 8176f2e67e...

Current branch diff-target is up to date.

Changes applied before test

commit f8385df4024949b04ed67ef99a10b1980e3ea6e1
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Sep 29 15:16:31 2021 +0200

    query_language/tokens.js: Add new visit types
    
    New visit types are or will be available in production so we
    must add them here or we will have an error when searching
    such origins.
    
    Related to T3424

See https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/296/ for more details.

Harbormaster completed remote builds in B24105: Diff 23188.Sep 29 2021, 3:46 PM

Closed by commit rDSEAf8385df40249: query_language/tokens.js: Add new visit types (authored by anlambert). · Explain WhySep 29 2021, 3:48 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDSEAf8385df40249: query_language/tokens.js: Add new visit types.