Differential D6282

HashableObject: Add type annotation for 'id' attribute
ClosedPublic
Actions

Authored by vlorentz on Sep 16 2021, 2:09 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDMODb6f5e30b53c8: HashableObject: Add type annotation for 'id' attribute

Summary

This class is a mixin that only works with classes that define
this attribute, so it makes sense to declare it.

It also allows generic functions (that take a HashableObject
parameter, such as D6281) to access it without 'type: ignore'.

Diff Detail

Repository

rDMOD Data model

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 23680
Build 36964: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 36963: arc lint + arc unit

Event Timeline

vlorentz created this revision.Sep 16 2021, 2:09 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 16 2021, 2:09 PM

vlorentz added a child revision: D6281: converters: Recompute hashes and check they match the originals.Sep 16 2021, 2:09 PM

Build is green

Patch application report for D6282 (id=22748)

Rebasing onto e8794971bd...

Current branch diff-target is up to date.

Changes applied before test

commit b6f5e30b53c8331b19a40a3c086af8ffa3a7e222
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Sep 16 14:09:15 2021 +0200

    HashableObject: Add type annotation for 'id' attribute
    
    This class is a mixin that only works with classes that define
    this attribute, so it makes sense to declare it.
    
    It also allows generic functions (that take a HashableObject
    parameter) to access it without 'type: ignore'.

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/369/ for more details.

Harbormaster completed remote builds in B23680: Diff 22748.Sep 16 2021, 2:11 PM

vlorentz requested review of this revision.Sep 16 2021, 2:11 PM

ardumont accepted this revision.Sep 16 2021, 2:15 PM

This revision is now accepted and ready to land.Sep 16 2021, 2:15 PM

Closed by commit rDMODb6f5e30b53c8: HashableObject: Add type annotation for 'id' attribute (authored by vlorentz). · Explain WhySep 16 2021, 2:21 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDMODb6f5e30b53c8: HashableObject: Add type annotation for 'id' attribute.