Page MenuHomeSoftware Heritage

templates/apidoc: Restore Web API links removed by JSON highlighting
ClosedPublic

Authored by anlambert on Sep 6 2021, 4:48 PM.

Details

Summary

Web API links generated by the urlize_links_and_mails template filter
are removed by highlight.js when highlighting JSON response.

So ensure to restore them once JSON highlighting has been performed.

Diff Detail

Repository
rDWAPPS Web applications
Branch
apidoc-fix-api-links
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 23387
Build 36497: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 36496: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D6191 (id=22419)

Rebasing onto ea485ffd9e...

Current branch diff-target is up to date.
Changes applied before test
commit 2904a0c4cb03fde3f59d49cffa44a215c5d0de39
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Sep 6 16:45:13 2021 +0200

    templates/apidoc: Restore Web API links removed by JSON highlighting
    
    Web API links generated by the urlize_links_and_mails template filter
    are removed by highlight.js when highlighting JSON response.
    
    So ensure to restore them once JSON highlighting has been performed.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1072/ for more details.

This revision is now accepted and ready to land.Sep 7 2021, 11:09 AM
This revision was landed with ongoing or failed builds.Sep 7 2021, 11:29 AM
This revision was automatically updated to reflect the committed changes.

Build is green

Patch application report for D6191 (id=22438)

Rebasing onto f17713fd89...

Current branch diff-target is up to date.
Changes applied before test
commit 8c8550a08afddfe00a7d1e06f21139709220ab81
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Sep 6 16:45:13 2021 +0200

    templates/apidoc: Restore Web API links removed by JSON highlighting
    
    Web API links generated by the urlize_links_and_mails template filter
    are removed by highlight.js when highlighting JSON response.
    
    So ensure to restore them once JSON highlighting has been performed.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1080/ for more details.