Differential D6049

Do not exclude falsy git objects from being added.
ClosedPublic
Actions

Authored by vlorentz on Jul 30 2021, 6:12 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDLDG92ef526eb663: Do not exclude falsy git objects from being added.

Summary

AFAICT that's only the empty tree, because trees are the only Dulwich object
with a len, and no Dulwich objects have a bool.

Diff Detail

Repository

rDLDG Git loader

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 22841
Build 35623: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 35622: arc lint + arc unit

Event Timeline

vlorentz created this revision.Jul 30 2021, 6:12 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 30 2021, 6:12 PM

Build is green

Patch application report for D6049 (id=21878)

Rebasing onto c67ab0269e...

Current branch diff-target is up to date.

Changes applied before test

commit 92ef526eb663d753405e5bbd20460f7300d67d51
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Jul 30 18:12:03 2021 +0200

    Do not exclude falsy git objects from being added.
    
    AFAICT that's only the empty tree, because trees are the only Dulwich object
    with a __len__, and no Dulwich objects have a __bool__.

See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/102/ for more details.

Harbormaster completed remote builds in B22841: Diff 21878.Jul 30 2021, 6:14 PM

vlorentz requested review of this revision.Jul 30 2021, 6:14 PM

lgtm

One remark inline.

swh/loader/git/from_disk.py
168	Note that this is the from_disk implementation, the one mostly (if not completely) used in production is the other one. Check swh.loader.git.tasks.UpdateGitRepository which is using swh.loader.git.loader.GitLoader.