Paths

Table of Contentst

Differential D6006

add winery backend
AcceptedPublic
Actions

Authored by dachary on Jul 19 2021, 12:28 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Summary

Related to: T3432

Test Plan

tox

Diff Detail

Repository

rDOBJS Object storage

Branch

wip-winery

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 22654
Build 35324: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 35323: arc lint + arc unit

Event Timeline

dachary created this revision.Jul 19 2021, 12:28 PM

Build is green

Patch application report for D6006 (id=21687)

Rebasing onto 37dcacf162...

Current branch diff-target is up to date.

Changes applied before test

commit 4cade7b99245f0493fc237536d638f09a88368c5
Author: Loïc Dachary <loic@dachary.org>
Date:   Mon Jul 19 12:21:19 2021 +0200

    add winery backend
    
    Summary: Related to: T3432
    
    Reviewers: #reviewers

See https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/25/ for more details.

Harbormaster completed remote builds in B22654: Diff 21687.Jul 19 2021, 12:31 PM

dachary requested review of this revision.Jul 19 2021, 12:31 PM

why *args, **kwargs on all methods?

swh/objstorage/backends/winery/__init__.py
12–13	that's implicit in py3 ;)

In D6006#154829, @vlorentz wrote:

why *args, **kwargs on all methods?

Because it's copy/pasted from the abstract methods in objstorage.py

dachary added inline comments.Jul 19 2021, 12:43 PM

swh/objstorage/backends/winery/__init__.py
12–13	True. It shows in other places therefore I figured it's tolerated :-)

vlorentz accepted this revision.Jul 19 2021, 12:54 PM

This revision is now accepted and ready to land.Jul 19 2021, 12:54 PM

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

swh/

objstorage/

backends/

winery/

__init__.py

66 lines

97%

tests/

test_objstorage_winery.py

18 lines

100%

Diff 21687

View Options

swh/objstorage/backends/winery/init.py