Improve `ProvenanceStorageInterface` for testing purposes
ClosedPublic
Actions

Authored by aeviso on Jul 6 2021, 2:50 PM.

Details

Reviewers

olasd

Group Reviewers

Reviewers

Commits

rDPROVc96beb57884d: Add `RevisionData` and `RelationData` to improve `ProvenanceStorageInterface`
rDPROV3003b15bf120: Add parametrize `batch` option to heuristics test
rDPROV9c383756bc5f: Add testing-specific methods to `ProvenanceStorageInterface`

Summary

Add testing-specific methods to ProvenanceStorageInterface

Refactor provenance_heuristics test so that it doesn't perform direct SQL queries,
hence being able to test different backends in the future.

Add parametrize batch option to heuristics test

Add RevisionData and RelationData to improve ProvenanceStorageInterface

Get read of Tuples in favour of more declarative objects for passing data.
Update the usage of the involved methods as well.

Diff Detail

Repository

rDPROV Provenance database

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

aeviso created this revision.Jul 6 2021, 2:50 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 6 2021, 2:50 PM

aeviso added a child revision: D5973: Reorganize code.Jul 6 2021, 2:51 PM

Build is green

Patch application report for D5972 (id=21514)

Rebasing onto 2e46f7c34b...

Current branch diff-target is up to date.

Changes applied before test

commit c246bd709270a6d5d407260f13cc666c18ab9819
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Tue Jul 6 13:48:50 2021 +0200

    Add `RevisionData` and `RelationData` to improve `ProvenanceStorageInterface`
    
    Get read of `Tuple`s in favour of more declarative objects for passing data.
    Update the usage of the involved methods as well.

commit 3003b15bf120734d8ee51472c594e117a6e9ea28
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Tue Jul 6 12:30:34 2021 +0200

    Add parametrize `batch` option to heuristics test

commit 9c383756bc5f232a338060f2b6f8872980b71119
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Tue Jul 6 12:22:21 2021 +0200

    Add testing-specific methods to `ProvenanceStorageInterface`
    
    Refactor `provenance_heuristics` test so that it doesn't perform direct SQL queries,
    hence being able to test different backends in the future.

See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/250/ for more details.

Harbormaster completed remote builds in B22487: Diff 21514.Jul 6 2021, 2:55 PM

aeviso requested review of this revision.Jul 6 2021, 2:55 PM

rebase

Build is green

Patch application report for D5972 (id=21582)

Rebasing onto 2e46f7c34b...

Current branch diff-target is up to date.

Changes applied before test

commit c96beb57884d19c7fd1fa74aa366f472187419ff
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Tue Jul 6 13:48:50 2021 +0200

    Add `RevisionData` and `RelationData` to improve `ProvenanceStorageInterface`
    
    Get read of `Tuple`s in favour of more declarative objects for passing data, and
    update the usage of the involved methods.
    
    Turn `ProvenanceResult` into a dataclass as well.

commit 3003b15bf120734d8ee51472c594e117a6e9ea28
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Tue Jul 6 12:30:34 2021 +0200

    Add parametrize `batch` option to heuristics test

commit 9c383756bc5f232a338060f2b6f8872980b71119
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Tue Jul 6 12:22:21 2021 +0200

    Add testing-specific methods to `ProvenanceStorageInterface`
    
    Refactor `provenance_heuristics` test so that it doesn't perform direct SQL queries,
    hence being able to test different backends in the future.

See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/255/ for more details.

Harbormaster completed remote builds in B22557: Diff 21582.Jul 9 2021, 2:46 PM

olasd accepted this revision.Jul 12 2021, 9:34 AM

This revision is now accepted and ready to land.Jul 12 2021, 9:34 AM

Closed by commit rDPROV9c383756bc5f: Add testing-specific methods to `ProvenanceStorageInterface` (authored by aeviso). · Explain WhyJul 12 2021, 11:18 AM

This revision was automatically updated to reflect the committed changes.

aeviso added a commit: rDPROV9c383756bc5f: Add testing-specific methods to `ProvenanceStorageInterface`.

aeviso added a commit: rDPROV3003b15bf120: Add parametrize `batch` option to heuristics test.

aeviso added a commit: rDPROVc96beb57884d: Add `RevisionData` and `RelationData` to improve `ProvenanceStorageInterface`.