Paths

Table of Contentst

Differential D5954

cli: Add commands to generate and revoke bearer tokens
ClosedPublic
Actions

Authored by anlambert on Jul 1 2021, 12:00 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T3385: Move `swh web auth` into a dedicated `swh auth` cli entrypoint

Commits

rDAUTH2da72f399b4d: cli: Add commands to generate and revoke bearer tokens

Summary

Migrate auth command group from swh-web-client package to the
swh-auth package.

Related to T3385

Related to D5955

Diff Detail

Repository

rDAUTH Common authentication libraries

Branch

auth-cli

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 22378
Build 34852: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 34851: arc lint + arc unit

Event Timeline

anlambert created this revision.Jul 1 2021, 12:00 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 1 2021, 12:00 PM

anlambert added a child revision: D5955: cli: Deprecate auth command group.Jul 1 2021, 12:01 PM

Build is green

Patch application report for D5954 (id=21383)

Rebasing onto b219038a6c...

Current branch diff-target is up to date.

Changes applied before test

commit e6e01fbfccead42ddaeb9c3b9c4646477fe0a844
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Jun 29 18:04:08 2021 +0200

    cli: Add commands to generate and revoke bearer tokens
    
    Migrate auth command group from swh-web-client package to the
    swh-auth package.
    
    Related to T3385

See https://jenkins.softwareheritage.org/job/DAUTH/job/tests-on-diff/83/ for more details.

Harbormaster completed remote builds in B22362: Diff 21383.Jul 1 2021, 12:02 PM

anlambert requested review of this revision.Jul 1 2021, 12:02 PM

anlambert edited the summary of this revision. (Show Details)Jul 1 2021, 12:07 PM

Great!

Some suggestions inline.

I gather some documentation update will happen later when
this is effectively the new way of generating token.

swh/auth/cli.py
69
swh/auth/tests/test_cli.py
53	to make it clear that's representing the user's input.
56	to be consistent ;)

ardumont accepted this revision.Jul 1 2021, 1:57 PM

This revision is now accepted and ready to land.Jul 1 2021, 1:57 PM

Update:

address @ardumont comments
add CLI section in swh-auth documentation

Build is green

Patch application report for D5954 (id=21399)

Rebasing onto b219038a6c...

Current branch diff-target is up to date.

Changes applied before test

commit 2da72f399b4d36a866d2d42e05681dd8d04b1a2b
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Jun 29 18:04:08 2021 +0200

    cli: Add commands to generate and revoke bearer tokens
    
    Migrate auth command group from swh-web-client package to the
    swh-auth package.
    
    Related to T3385

See https://jenkins.softwareheritage.org/job/DAUTH/job/tests-on-diff/84/ for more details.

Harbormaster completed remote builds in B22378: Diff 21399.Jul 1 2021, 3:15 PM

Closed by commit rDAUTH2da72f399b4d: cli: Add commands to generate and revoke bearer tokens (authored by anlambert). · Explain WhyJul 1 2021, 3:16 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDAUTH2da72f399b4d: cli: Add commands to generate and revoke bearer tokens.