Convert Revision.date from` TimestampWithTimezone` to datetime as expected by` RevisionEntry`.
Create a list with the iterator returned by ArchiveInterface.revision_get () before comparison.
Details
Details
- Reviewers
douardda - Group Reviewers
Reviewers - Commits
- rDPROVe6f39d0244b1: Fix bugs when retrieving parents in RevisionEntry
Diff Detail
Diff Detail
- Repository
- rDPROV Provenance database
- Branch
- master
- Lint
Lint Skipped - Unit
Unit Tests Skipped - Build Status
Buildable 22157 Build 34479: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 34478: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
Patch application report for D5884 (id=21084)
Rebasing onto c9d1369ba1...
Current branch diff-target is up to date.
Changes applied before test
commit 12edf4a3b7992575f5f24cd8a648c803dbda142a
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date: Thu Jun 17 13:48:24 2021 +0200
Fix bugs when retrieven parents in RevisionEntrySee https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/144/ for more details.
Comment Actions
Thanks a lot for the split.
A few things and we are good:
- there is typo in the commit message
- it would be nice for this commit message to describe which bugs are being fixed
- use to_datetime() (remember to bump the version dependency on swh.model for this)
Thanks
| swh/provenance/model.py | ||
|---|---|---|
| 97 | please use the new TimestampWithTimwzone.to_datetime() recently added in swh.model (in v2.6.0) instead. | |
| swh/provenance/model.py | ||
|---|---|---|
| 97 | sure. It just wasn't there when this modification was originally done | |
Comment Actions
Build is green
Patch application report for D5884 (id=21130)
Rebasing onto 8ff1ab5860...
Current branch diff-target is up to date.
Changes applied before test
commit d28d3eed7049e36c5841405021fd0a0e78c11cb7
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date: Thu Jun 17 13:48:24 2021 +0200
Fix bugs when retrieving parents in RevisionEntry
Convert `Revision.date` from` TimestampWithTimezone` to `datetime` as expected by` RevisionEntry`.
Create a list with the iterator returned by `ArchiveInterface.revision_get ()` before comparison.See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/161/ for more details.
| swh/provenance/model.py | ||
|---|---|---|
| 97 |
indeed, since I've added it explicitly for this :-) | |
Comment Actions
thanks, the diff looks much simpler now :-)
Just include the version constraint (swh.model >= 2.6) in requirements-swh.txt and we are good.
Comment Actions
Build is green
Patch application report for D5884 (id=21138)
Rebasing onto 8ff1ab5860...
Current branch diff-target is up to date.
Changes applied before test
commit cd48f9d71efeaf73cfcc24f397d22589a5f7987b
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date: Thu Jun 17 13:48:24 2021 +0200
Fix bugs when retrieving parents in RevisionEntry
Convert `Revision.date` from` TimestampWithTimezone` to `datetime` as expected by` RevisionEntry`.
Create a list with the iterator returned by `ArchiveInterface.revision_get()` before comparison.See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/166/ for more details.
Comment Actions
Build is green
Patch application report for D5884 (id=21170)
Rebasing onto 011645221c...
Current branch diff-target is up to date.
Changes applied before test
commit e6f39d0244b10b49942b0ab93d4628828e343642
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date: Thu Jun 17 13:48:24 2021 +0200
Fix bugs when retrieving parents in RevisionEntry
Convert `Revision.date` from` TimestampWithTimezone` to `datetime` as expected by` RevisionEntry`.
Create a list with the iterator returned by `ArchiveInterface.revision_get()` before comparison.See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/176/ for more details.