Paths

Table of Contentst

Update running save origin request status
ClosedPublic
Actions

Authored by vsellier on Jun 2 2021, 12:07 PM.

Details

Reviewers

ardumont
anlambert

Group Reviewers

Reviewers

Maniphest Tasks

T3355: Running save code now request are never detected as completed by the webapp

Commits

rDWAPPS267e8365f0d6: Update running save origin request status

Summary

If a SOR was updated as running (i.e the visit is in progress when the
refresh job is executed), it's status was never refreshed when its
completed

Related to T3355

Diff Detail

Repository

rDWAPPS Web applications

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 21706
Build 33737: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 33736: arc lint + arc unit

Event Timeline

vsellier created this revision.Jun 2 2021, 12:07 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 2 2021, 12:07 PM

ardumont mentioned this in D5788: common/origin_save: Update missing information when available.Jun 2 2021, 12:09 PM

Build is green

Patch application report for D5810 (id=20744)

Rebasing onto 5f58eb5cd4...

Current branch diff-target is up to date.

Changes applied before test

commit 2f3a7955fe22edd3da400ee2e743cb03ab7fd49c
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date:   Wed Jun 2 12:03:01 2021 +0200

    Update running save origin request status
    
    If a SOR was updated as running (i.e the visit is in progress when the
    refresh job is executed), it's status was never refreshed when it's
    completed
    
    Related to T3355

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/856/ for more details.

Harbormaster completed remote builds in B21706: Diff 20744.Jun 2 2021, 12:18 PM

vsellier requested review of this revision.Jun 2 2021, 12:18 PM

Thank you!

This revision is now accepted and ready to land.Jun 2 2021, 12:19 PM

vsellier edited the summary of this revision. (Show Details)Jun 2 2021, 12:20 PM

fix typo in commit message

Thanks! I guess you can tag and deploy a new version of swh-web once it is landed.

Build has FAILED

Patch application report for D5810 (id=20745)

Rebasing onto 5f58eb5cd4...

Current branch diff-target is up to date.

Changes applied before test

commit 267e8365f0d6a222d0c1bf9dbfd4b53befb1f217
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date:   Wed Jun 2 12:03:01 2021 +0200

    Update running save origin request status
    
    If a SOR was updated as running (i.e the visit is in progress when the
    refresh job is executed), it's status was never refreshed when its
    completed
    
    Related to T3355

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/857/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/857/console

Harbormaster failed remote builds in B21707: Diff 20745!Jun 2 2021, 12:34 PM

Build is green

Patch application report for D5810 (id=20745)

Rebasing onto 5f58eb5cd4...

Current branch diff-target is up to date.

Changes applied before test

commit 267e8365f0d6a222d0c1bf9dbfd4b53befb1f217
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date:   Wed Jun 2 12:03:01 2021 +0200

    Update running save origin request status
    
    If a SOR was updated as running (i.e the visit is in progress when the
    refresh job is executed), it's status was never refreshed when its
    completed
    
    Related to T3355

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/858/ for more details.

Harbormaster completed remote builds in B21707: Diff 20745.Jun 2 2021, 12:47 PM

Closed by commit rDWAPPS267e8365f0d6: Update running save origin request status (authored by vsellier). · Explain WhyJun 2 2021, 2:17 PM

This revision was automatically updated to reflect the committed changes.

vsellier added a commit: rDWAPPS267e8365f0d6: Update running save origin request status.