Page MenuHomeSoftware Heritage
Differential D5745

Make get_swhid() more pythonic
ClosedPublic
Actions

Authored by vlorentz on May 17 2021, 2:31 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDWAPPSa33f56e5ff1d: Make get_swhid() more pythonic
Summary

https://docs.python.org/3/library/stdtypes.html#str.partition

Diff Detail

Repository
rDWAPPS Web applications
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 21516
Build 33429: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 33428: arc lint + arc unit

Event Timeline

vlorentz created this revision.May 17 2021, 2:31 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptMay 17 2021, 2:31 PM
swh-public-ci added a comment.May 17 2021, 2:32 PM

Build has FAILED

Patch application report for D5745 (id=20536)

Rebasing onto 8157fd1c35...

Current branch diff-target is up to date.
Changes applied before test
commit a33f56e5ff1d92dbb2d3f8b9eae9d2aed233f448
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon May 17 14:30:45 2021 +0200

    Make get_swhid() more pythonic

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/829/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/829/console

Harbormaster returned this revision to the author for changes because remote builds failed.May 17 2021, 2:32 PM
Harbormaster failed remote builds in B21516: Diff 20536!
vlorentz requested review of this revision.May 17 2021, 2:33 PM

(test failure is not related to this diff)

ardumont added a subscriber: ardumont.May 17 2021, 3:28 PM

lgtm (and clearer ;)

swh/web/common/identifiers.py
238–239

directly?

ardumont accepted this revision.May 17 2021, 3:32 PM
This revision is now accepted and ready to land.May 17 2021, 3:32 PM
vlorentz added inline comments.May 17 2021, 3:34 PM
swh/web/common/identifiers.py
238–239

I don't know, I find it a little clearer with .lower() on its own line

This revision was landed with ongoing or failed builds.May 17 2021, 4:32 PM
Closed by commit rDWAPPSa33f56e5ff1d: Make get_swhid() more pythonic (authored by vlorentz). · Explain Why
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDWAPPSa33f56e5ff1d: Make get_swhid() more pythonic.

Revision Contents
Changeset List

PathSize
swh/
web/
common/
11 lines

Diff 20536

View Options

swh/web/common/identifiers.py

Loading...
About · Developer information · Legal