This also contains a first commit which introduced SETTINGS_{DEV,TEST,PROD} variable.
Context: I had issues troubleshooting ui without those specific user.
Related to T3213
Details
Details
make something and check existing behavior is still ok
Diff Detail
Diff Detail
- Repository
- rDWAPPS Web applications
- Branch
- add-new-bundle
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 21430 Build 33291: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 33290: arc lint + arc unit
Event Timeline
| Makefile.local | ||
|---|---|---|
| 30 | I tried some form where the DJANGO_SETTINGS_MODULE was set instead [1] to no avail. [1] something like settings-dev:
export DJANGO_SETTINGS_MODULE=$(SETTINGS_DEV)
run-migrations-dev: settings-dev
django-admin migrate -v0 2>/dev/null
...
# same goes on for settings-prod, settings-test, ... | |
Comment Actions
Build is green
Patch application report for D5725 (id=20453)
Could not rebase; Attempt merge onto 1e97586914...
Updating 1e975869..7dac2806 Fast-forward Makefile.local | 61 ++++++++----- assets/src/bundles/save/index.js | 40 +++++++-- cypress/integration/origin-save.spec.js | 79 +++++++++++++++++ cypress/support/index.js | 4 + swh/web/api/views/origin_save.py | 12 +-- swh/web/auth/utils.py | 13 ++- swh/web/common/origin_save.py | 133 +++++++++++++++++++++------- swh/web/common/swh_templatetags.py | 7 +- swh/web/common/typing.py | 2 +- swh/web/misc/origin_save.py | 8 +- swh/web/templates/misc/origin-save.html | 22 ++++- swh/web/tests/api/test_throttling.py | 15 +--- swh/web/tests/api/views/test_origin_save.py | 72 ++++++++++++++- swh/web/tests/common/test_origin_save.py | 61 ++++++++++++- swh/web/tests/create_test_users.py | 23 +++-- swh/web/tests/misc/test_origin_save.py | 45 ++++++++-- swh/web/tests/test_create_users.py | 16 ++++ swh/web/tests/utils.py | 24 ++++- 18 files changed, 533 insertions(+), 104 deletions(-) create mode 100644 swh/web/tests/test_create_users.py
Changes applied before test
commit 7dac28063ef5be385cbf35518ef188a7ca9f9c48
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Mon May 10 17:16:51 2021 +0200
Makefile.local: Install users per environment
Related to T3213
commit 77c5825ce2a6df15b004f3906541f08199624880
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Mon May 10 17:11:27 2021 +0200
Makefile.local: Reuse SETTINGS_{DEV,TEST,PROD} variable
To avoid repetition
commit 6a9fcdd3b9d79d180407ee7f5fc9a8b36a54e30e
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Mon May 10 15:53:32 2021 +0200
save-code-now: Rename origin type 'bundle' to 'archives'
Related to T3213
commit 34bbf06e4e29c95d92c3c458b35c715432662e17
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Wed May 5 15:41:34 2021 +0200
Allow privileged user to trigger save code now bundle visit type
Related to T3213
commit ee8ece2e6b2c2820a2ee493f9f7f7ff987eaa6f4
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Thu May 6 14:05:15 2021 +0200
tests: Add new ambassador user for frontend tests
This refactor existing permission code to allow creation of user with some permissions.
This reworks the Makefile.local to create the users accordingly in different targets.
Related to T3213
commit 2a4f2e966a034e034a736e7e10b2b572ef32c89b
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Wed May 5 15:25:33 2021 +0200
Add new bundle type to list only when connected as privileged user
This is only doing listing for now. It's in a dedicated commit so review is easier.
Some more work is required ui and server side to actually schedule those new visit type.
It will be done in a future commit.
Related to T3213See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/821/ for more details.