Differential D5714

sourceforge/lister: Add credentials parameter
ClosedPublic
Actions

Authored by ardumont on May 7 2021, 4:11 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Maniphest Tasks

T3310: Deploy sourceforge lister on staging

Commits

rDLS7282647bb2d3: sourceforge/lister: Add credentials parameter

Summary

This are not optional due to the instance constructor logic. Even if unused, this must
be provided to the lister.

Related to T3310#64801

Test Plan

tox

Diff Detail

Repository

rDLS Listers

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 21393
Build 33231: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 33230: arc lint + arc unit

Event Timeline

ardumont created this revision.May 7 2021, 4:11 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 7 2021, 4:11 PM

Build is green

Patch application report for D5714 (id=20414)

Rebasing onto 3167a6dcb7...

Current branch diff-target is up to date.

Changes applied before test

commit 67a4107176540555760ef465991fe991fc0bd700
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri May 7 16:10:11 2021 +0200

    sourceforge/lister: Add credentials parameter
    
    This are not optional due to the instance constructor logic. Even if unused, this must
    be provided to the lister.
    
    Related to T3310#64801

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/278/ for more details.

Harbormaster completed remote builds in B21392: Diff 20414.May 7 2021, 4:14 PM

ardumont requested review of this revision.May 7 2021, 4:14 PM

anlambert accepted this revision.May 7 2021, 4:24 PM

This revision is now accepted and ready to land.May 7 2021, 4:24 PM

Reword commit message

Build is green

Patch application report for D5714 (id=20415)

Rebasing onto 3167a6dcb7...

Current branch diff-target is up to date.

Changes applied before test

commit 7282647bb2d3351182a6fc115eb64bee4bb83bb7
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri May 7 16:10:11 2021 +0200

    sourceforge/lister: Add credentials parameter
    
    The credentials parameter is not optional due to the instance constructor logic. Even if
    unused, this must be provided to the lister (from the task standpoint).
    
    Related to T3310#64801

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/279/ for more details.

Harbormaster completed remote builds in B21393: Diff 20415.May 7 2021, 4:50 PM

Closed by commit rDLS7282647bb2d3: sourceforge/lister: Add credentials parameter (authored by ardumont). · Explain WhyMay 7 2021, 4:52 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDLS7282647bb2d3: sourceforge/lister: Add credentials parameter.