Details
Details
- Reviewers
Alphare - Group Reviewers
Reviewers - Commits
- rDLDHG2a0b96c1de93: HgLoaderFromDisk: Fix type annotation
Diff Detail
Diff Detail
- Repository
- rDLDHG Mercurial loader
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 20330 Build 31562: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 31561: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
Patch application report for D5370 (id=19243)
Could not rebase; Attempt merge onto a62318d725...
Updating a62318d..8618e38 Fast-forward swh/loader/mercurial/from_disk.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
Changes applied before test
commit 8618e381a56fa87842f09a7f64a27f36e097fdf6
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Mon Mar 29 13:10:47 2021 +0200
HgLoaderFromDisk: Fix type annotation
commit 69f4b023b3ecf21e23838a46935069245dcfd118
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Mon Mar 29 12:34:36 2021 +0200
HgLoaderFromDisk: Don't query revision_get with release ids
This is a minor performance optimization, removing items from the
call to revision_get when we know their result will be None.
Motivation: A future commit will refactor this function, and dealing only
with revision ids makes it simpler.See https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/188/ for more details.
Comment Actions
Build is green
Patch application report for D5370 (id=19262)
Could not rebase; Attempt merge onto 020791c464...
Updating 020791c..2a0b96c Fast-forward swh/loader/mercurial/from_disk.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
Changes applied before test
commit 2a0b96c1de935e772f7cd05344ed47acd670a448
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Mon Mar 29 13:10:47 2021 +0200
HgLoaderFromDisk: Fix type annotation
commit 428d764c403c4d69c802e989bc5cf001b614921e
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Mon Mar 29 12:34:36 2021 +0200
HgLoaderFromDisk: Don't query revision_get with release ids
This is a minor performance optimization, removing items from the
call to revision_get when we know their result will be None.
Motivation: A future commit will refactor this function, and dealing only
with revision ids makes it simpler.See https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/195/ for more details.