Differential D5314

cran, npm, pypi: Add the loader name in the ExtID type
ClosedPublic
Actions

Authored by vlorentz on Mar 23 2021, 6:29 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDLDBASE6d3545e47b5e: cran, npm, pypi: Add the loader name in the ExtID type

Summary

These three loaders get intrinsic metadata from the archive, and use it
to build the revision object (mostly authoring and date), which means
they would not load the same revision as an other loader given the
same archive.

Addresses the comments on e9a8f986809cc611d540e68d30c7bfac5166e968.

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 20157
Build 31291: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 31290: arc lint + arc unit

Event Timeline

vlorentz created this revision.Mar 23 2021, 6:29 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 23 2021, 6:29 PM

Build is green

Patch application report for D5314 (id=19065)

Rebasing onto 5fd7619fb2...

Current branch diff-target is up to date.

Changes applied before test

commit 6d3545e47b5e32b98eb0a32717406849063e1bbf
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Mar 23 18:28:39 2021 +0100

    cran, npm, pypi: Add the loader name in the ExtID type
    
    These three loaders get intrinsic metadata from the archive, and use it
    to build the revision object (mostly authoring and date), which means
    they would not load the same revision as an other loader given the
    same archive.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/438/ for more details.

Harbormaster completed remote builds in B20157: Diff 19065.Mar 23 2021, 6:30 PM

vlorentz requested review of this revision.Mar 23 2021, 6:30 PM

ardumont accepted this revision.Mar 23 2021, 6:36 PM

This revision is now accepted and ready to land.Mar 23 2021, 6:36 PM

Closed by commit rDLDBASE6d3545e47b5e: cran, npm, pypi: Add the loader name in the ExtID type (authored by vlorentz). · Explain WhyMar 23 2021, 6:39 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDLDBASE6d3545e47b5e: cran, npm, pypi: Add the loader name in the ExtID type.