Differential D5254

Rename 'git_metadata' to 'extra_headers'
ClosedPublic
Actions

Authored by vlorentz on Mar 16 2021, 11:38 AM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDLDG1eb1c57389e1: Rename 'git_metadata' to 'extra_headers'

Summary

Because they are now stored in the 'extra_headers' field instead
of the 'metadata' field.

Motivation: consistency + keep it out of 'grep metadata */swh/ -r'

Diff Detail

Repository

rDLDG Git loader

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 19932
Build 30956: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 30955: arc lint + arc unit

Event Timeline

vlorentz created this revision.Mar 16 2021, 11:38 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 16 2021, 11:38 AM

Build is green

Patch application report for D5254 (id=18838)

Rebasing onto 342f8fde25...

Current branch diff-target is up to date.

Changes applied before test

commit 1eb1c57389e1545496867e81d0f3c39a9bde036c
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Mar 16 11:38:39 2021 +0100

    Rename 'git_metadata' to 'extra_headers'
    
    Because they are now stored in the 'extra_headers' field instead
    of the 'metadata' field.
    
    Motivation: consistency + keep it out of 'grep metadata */swh/ -r'

See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/92/ for more details.

Harbormaster completed remote builds in B19932: Diff 18838.Mar 16 2021, 11:40 AM

vlorentz requested review of this revision.Mar 16 2021, 11:40 AM

anlambert accepted this revision.Mar 16 2021, 12:00 PM

This revision is now accepted and ready to land.Mar 16 2021, 12:00 PM

Closed by commit rDLDG1eb1c57389e1: Rename 'git_metadata' to 'extra_headers' (authored by vlorentz). · Explain WhyMar 16 2021, 12:25 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDLDG1eb1c57389e1: Rename 'git_metadata' to 'extra_headers'.