Differential D615

sql/40-swh-data: Update new indexer task types for local db
ClosedPublic
Actions

Authored by ardumont on Oct 26 2018, 9:34 PM.

Details

Reviewers

vlorentz

Commits

rDSCH4b050322e8dd: sql/40-swh-data: Update new indexer task types for local db

Summary

Those new types need to be deployed in production when the new indexer
will hit production.

Note: That file is not in charge of doing so.

Depends on D606
Depends on D609
Depends on D612

Related T1290

Diff Detail

Repository

rDSCH Scheduling utilities

Branch

update-sql-data

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 1962
Build 2369: tox-on-jenkins	Jenkins
Build 2368: arc lint + arc unit

Event Timeline

ardumont created this revision.Oct 26 2018, 9:34 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSCH/job/tox/20/ for more details.

Harbormaster completed remote builds in B1962: Diff 1874.Oct 26 2018, 9:37 PM

ardumont mentioned this in D606: Use swh.scheduler instead of celery in the orchestrator..Oct 27 2018, 9:59 AM

Doesn't this need a migration as well?

This revision now requires changes to proceed.Oct 29 2018, 9:10 AM

Doesn't this need a migration as well?

We are inconsistent in that module.
We do not do migrations. I do not know why.

I'm ok for bootstraping it though.

vlorentz accepted this revision.Oct 29 2018, 9:25 AM

This revision is now accepted and ready to land.Oct 29 2018, 9:25 AM

In D615#12118, @ardumont wrote:

Doesn't this need a migration as well?

We are inconsistent in that module.
We do not do migrations. I do not know why.

I'm ok for bootstraping it though.

Poppycock! There are already (cf. sql/update/...).
I remember now that the data itself (as in task-type for example) is not something that triggers an upgrade (check the sql/update/*.sql, you will not see any data insert in there, except for the dbversion bump)
I do not know why.