Differential D5206

Use CoreSWHID instead of the deprecated/removed SWHID class
ClosedPublic
Actions

Authored by vlorentz on Mar 5 2021, 4:28 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDLDHGc1808d132f19: Use CoreSWHID instead of the deprecated/removed SWHID class

Summary

Required to silence warnings with swh-model 1.0.0,
and error with swh-model >= 1.0.1

Diff Detail

Repository

rDLDHG Mercurial loader

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 19741
Build 30642: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 30641: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	963 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.loader.mercurial.tests.test_identify::test_all datadir = '/var/lib/jenkins/workspace/DLDHG/tests-on-diff/.tox/py3/lib/python3.7/site-packages/swh/loader/mercurial/tests/data' tmp_path = PosixPath('/tmp/pytest-of-jenkins/pytest-0/test_all0')
	926 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.loader.mercurial.tests.test_identify::test_all_revisions datadir = '/var/lib/jenkins/workspace/DLDHG/tests-on-diff/.tox/py3/lib/python3.7/site-packages/swh/loader/mercurial/tests/data' tmp_path = PosixPath('/tmp/pytest-of-jenkins/pytest-0/test_all_revisions0')
	490 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.loader.mercurial.tests.test_identify::test_single_revision datadir = '/var/lib/jenkins/workspace/DLDHG/tests-on-diff/.tox/py3/lib/python3.7/site-packages/swh/loader/mercurial/tests/data' tmp_path = PosixPath('/tmp/pytest-of-jenkins/pytest-0/test_single_revision0')
	2 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.loader.mercurial.tests.test_converters.TestParseAuthorConverters::test_parse_author_2
	1 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.loader.mercurial.tests.test_converters.TestParseAuthorConverters::test_parse_author_3
		View Full Test Results (3 Failed · 42 Passed)

Event Timeline

vlorentz created this revision.Mar 5 2021, 4:28 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 5 2021, 4:28 PM

Build has FAILED

Patch application report for D5206 (id=18648)

Rebasing onto 1b4780030e...

Current branch diff-target is up to date.

Changes applied before test

commit 9f867db2434a6c707cfcf63dfe08bc6e49449be4
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Mar 5 16:28:23 2021 +0100

    Use CoreSWHID instead of the deprecated/removed SWHID class
    
    Required to silence warnings with swh-model 1.0.0,
    and error with swh-model >= 1.0.1

Link to build: https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/182/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/182/console

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 5 2021, 4:30 PM

Harbormaster failed remote builds in B19741: Diff 18648!

fix tests

Build is green

Patch application report for D5206 (id=18649)

Rebasing onto 1b4780030e...

Current branch diff-target is up to date.

Changes applied before test

commit c1808d132f19624996782dc8643459d9325d5e5e
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Mar 5 16:28:23 2021 +0100

    Use CoreSWHID instead of the deprecated/removed SWHID class
    
    Required to silence warnings with swh-model 1.0.0,
    and error with swh-model >= 1.0.1

See https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/183/ for more details.

Harbormaster completed remote builds in B19742: Diff 18649.Mar 5 2021, 4:45 PM

vlorentz requested review of this revision.Mar 5 2021, 4:45 PM

ardumont accepted this revision.Mar 5 2021, 4:50 PM

This revision is now accepted and ready to land.Mar 5 2021, 4:50 PM

Closed by commit rDLDHGc1808d132f19: Use CoreSWHID instead of the deprecated/removed SWHID class (authored by vlorentz). · Explain WhyMar 5 2021, 5:09 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDLDHGc1808d132f19: Use CoreSWHID instead of the deprecated/removed SWHID class.