Details
Details
- Reviewers
ardumont - Group Reviewers
Reviewers - Maniphest Tasks
- T2867: Webapp search UI: set focus on search input by default
- Commits
- rDWAPPSf34eca75210d: templates/origin-search-form: Set autofocus to search input
Diff Detail
Diff Detail
- Repository
- rDWAPPS Web applications
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build is green
Patch application report for D5109 (id=18251)
Could not rebase; Attempt merge onto 4c5f47bd30...
Updating 4c5f47bd..f34eca75 Fast-forward cypress/integration/home.spec.js | 13 ++++++++++++- cypress/integration/origin-search.spec.js | 16 ++++++++++++---- swh/web/assets/src/bundles/browse/origin-search.js | 6 +++--- swh/web/templates/includes/origin-search-form.html | 4 +++- 4 files changed, 30 insertions(+), 9 deletions(-)
Changes applied before test
commit f34eca75210d17cdd74686cef92be76783dc91eb Author: Antoine Lambert <antoine.lambert@inria.fr> Date: Thu Feb 18 15:36:21 2021 +0100 templates/origin-search-form: Set autofocus to search input It ensures that search input will have keyboard focus when loading a page where the search form is included. Closes T2867 commit 51672d511105bad0635b6330ba8084090dc75073 Author: Antoine Lambert <antoine.lambert@inria.fr> Date: Thu Feb 18 14:42:24 2021 +0100 templates/origin-search-form: Rename search input identifier Add swh- prefix for consistency.
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/580/ for more details.