Differential D5105

templates/layout: Display ribbon for staging instances of swh-web
ClosedPublic
Actions

Authored by anlambert on Feb 18 2021, 11:49 AM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T2781: Make it obvious that services are the staging version

Commits

rDWAPPS4c5f47bd301d: templates/layout: Display ribbon for staging instances of swh-web

Summary

In order to to have an obvious distinction between staging and production
instances of swh-web add a Staging ribbon in the top right part of the UI.

Related to T2781

Diff Detail

Repository

rDWAPPS Web applications

Branch

staging-add-ribbon

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 19328
Build 29967: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 29966: arc lint + arc unit

Event Timeline

anlambert created this revision.Feb 18 2021, 11:49 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 18 2021, 11:49 AM

Build has FAILED

Patch application report for D5105 (id=18227)

Rebasing onto a38de155cc...

Current branch diff-target is up to date.

Changes applied before test

commit 542f58a29c2da19ed478afba80804e6c4ab008cb
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Feb 18 11:45:45 2021 +0100

    templates/layout: Display ribbon for staging instances of swh-web
    
    In order to to have an obvious distinction between staging and production
    instances of swh-web add a Staging ribbon in the top right part of the UI.
    
    Related to T2781

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/577/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/577/console

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 18 2021, 11:55 AM

Harbormaster failed remote builds in B19324: Diff 18227!

Fix tests

Build is green

Patch application report for D5105 (id=18231)

Rebasing onto a38de155cc...

Current branch diff-target is up to date.

Changes applied before test

commit 4c5f47bd301d7b26268af736f090ec001ef44f1f
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Feb 18 11:45:45 2021 +0100

    templates/layout: Display ribbon for staging instances of swh-web
    
    In order to to have an obvious distinction between staging and production
    instances of swh-web add a Staging ribbon in the top right part of the UI.
    
    Related to T2781

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/578/ for more details.

Harbormaster completed remote builds in B19328: Diff 18231.Feb 18 2021, 12:21 PM

anlambert requested review of this revision.Feb 18 2021, 12:21 PM

ardumont accepted this revision.Feb 18 2021, 12:29 PM

This revision is now accepted and ready to land.Feb 18 2021, 12:29 PM

Closed by commit rDWAPPS4c5f47bd301d: templates/layout: Display ribbon for staging instances of swh-web (authored by anlambert). · Explain WhyFeb 18 2021, 12:31 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS4c5f47bd301d: templates/layout: Display ribbon for staging instances of swh-web.