Page MenuHomeSoftware Heritage
Differential D5076

loader: Expect visit_date as an optional date in constructors
ClosedPublic
Actions

Authored by ardumont on Feb 15 2021, 6:00 PM.

Details

Reviewers
anlambert
Group Reviewers
Reviewers
Maniphest Tasks
T1410: Kill implicit configuration: new configuration scheme
Commits
rDLDSVNeead508f0afe: loader: Expect visit_date as an optional date in constructors
Summary

This avoids side-effect in the constructor and also aligns how it's done in other
loaders (e.g git).

Depends on D5075
Related to T1410

Diff Detail

Event Timeline

ardumont created this revision.Feb 15 2021, 6:00 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 15 2021, 6:00 PM
swh-public-ci added a comment.Feb 15 2021, 6:01 PM

Build has FAILED

Patch application report for D5076 (id=18117)

Could not rebase; Attempt merge onto 71e3b44784...

Updating 71e3b44..78930b4
Fast-forward
 mypy.ini                            |   5 +-
 requirements.txt                    |   1 +
 swh/loader/svn/loader.py            | 111 ++++++++++++++++++++----------------
 swh/loader/svn/tasks.py             |  93 +++++++++++++++++++++---------
 swh/loader/svn/tests/conftest.py    |  44 +++++++-------
 swh/loader/svn/tests/test_loader.py |  92 ++++++++++++++++--------------
 6 files changed, 206 insertions(+), 140 deletions(-)
Changes applied before test
commit 78930b4fca5dbcf428e0ac0826dca0e4bc3ef086
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Sun Feb 7 08:55:36 2021 +0100

    loader: Expect visit_date as an optional date in constructors
    
    This avoids side-effect in the constructor and also aligns how it's done in other
    loaders (e.g git).

commit 727189d56849edd8481db1d6d4b7919c1e935aff
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Sun Feb 7 08:45:16 2021 +0100

    Rework loader instantiation logic according to loader core api
    
    Note that this also updated some docstrings and type along the way.

Link to build: https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/112/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/112/console

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 15 2021, 6:01 PM
Harbormaster failed remote builds in B19221: Diff 18117!
ardumont updated this revision to Diff 18121.Feb 15 2021, 6:04 PM

Rebase

swh-public-ci added a comment.Feb 15 2021, 6:04 PM

Build has FAILED

Patch application report for D5076 (id=18121)

Could not rebase; Attempt merge onto 71e3b44784...

Updating 71e3b44..22ad2dd
Fast-forward
 mypy.ini                            |   5 +-
 requirements-swh.txt                |   2 +-
 requirements.txt                    |   1 +
 swh/loader/svn/loader.py            | 111 ++++++++++++++++++++----------------
 swh/loader/svn/tasks.py             |  93 +++++++++++++++++++++---------
 swh/loader/svn/tests/conftest.py    |  44 +++++++-------
 swh/loader/svn/tests/test_loader.py |  92 ++++++++++++++++--------------
 7 files changed, 207 insertions(+), 141 deletions(-)
Changes applied before test
commit 22ad2ddae2bc1d19d7127a5955c6ae0adb3fd56d
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Sun Feb 7 08:55:36 2021 +0100

    loader: Expect visit_date as an optional date in constructors
    
    This avoids side-effect in the constructor and also aligns how it's done in other
    loaders (e.g git).
    
    Related to T1410

commit 69b218f8e22298d21d39b11893c3045bb6cedec8
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Sun Feb 7 08:45:16 2021 +0100

    Rework loader instantiation logic according to loader core api
    
    Note that this also updated some docstrings and type along the way.
    
    Related to T1410

Link to build: https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/115/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/115/console

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 15 2021, 6:04 PM
Harbormaster failed remote builds in B19225: Diff 18121!
ardumont updated this revision to Diff 18183.Feb 17 2021, 1:08 PM

Rebase

swh-public-ci added a comment.Feb 17 2021, 1:09 PM

Build has FAILED

Patch application report for D5076 (id=18183)

Could not rebase; Attempt merge onto 71e3b44784...

Updating 71e3b44..2dd86f5
Fast-forward
 mypy.ini                            |   5 +-
 requirements-swh.txt                |   2 +-
 requirements.txt                    |   1 +
 swh/loader/svn/loader.py            | 123 ++++++++++++++++++++----------------
 swh/loader/svn/tasks.py             |  93 +++++++++++++++++++--------
 swh/loader/svn/tests/conftest.py    |  44 +++++++------
 swh/loader/svn/tests/test_loader.py |  92 ++++++++++++++-------------
 7 files changed, 213 insertions(+), 147 deletions(-)
Changes applied before test
commit 2dd86f5e101432242ffdbdd1c2c1cf37dc8de317
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Sun Feb 7 08:55:36 2021 +0100

    loader: Expect visit_date as an optional date in constructors
    
    This avoids side-effect in the constructor and also aligns how it's done in other
    loaders (e.g git).
    
    Related to T1410

commit 5ad2709b12881a8b8a65488a82d7dfc5a0cbb48c
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Sun Feb 7 08:45:16 2021 +0100

    Rework loader instantiation logic according to loader core api
    
    Note that this also updated some docstrings and type along the way.
    
    Related to T1410

Link to build: https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/117/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/117/console

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 17 2021, 1:09 PM
Harbormaster failed remote builds in B19284: Diff 18183!
swh-public-ci added a comment.Feb 17 2021, 1:27 PM

Build is green

Patch application report for D5076 (id=18183)

Could not rebase; Attempt merge onto 71e3b44784...

Updating 71e3b44..2dd86f5
Fast-forward
 mypy.ini                            |   5 +-
 requirements-swh.txt                |   2 +-
 requirements.txt                    |   1 +
 swh/loader/svn/loader.py            | 123 ++++++++++++++++++++----------------
 swh/loader/svn/tasks.py             |  93 +++++++++++++++++++--------
 swh/loader/svn/tests/conftest.py    |  44 +++++++------
 swh/loader/svn/tests/test_loader.py |  92 ++++++++++++++-------------
 7 files changed, 213 insertions(+), 147 deletions(-)
Changes applied before test
commit 2dd86f5e101432242ffdbdd1c2c1cf37dc8de317
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Sun Feb 7 08:55:36 2021 +0100

    loader: Expect visit_date as an optional date in constructors
    
    This avoids side-effect in the constructor and also aligns how it's done in other
    loaders (e.g git).
    
    Related to T1410

commit 5ad2709b12881a8b8a65488a82d7dfc5a0cbb48c
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Sun Feb 7 08:45:16 2021 +0100

    Rework loader instantiation logic according to loader core api
    
    Note that this also updated some docstrings and type along the way.
    
    Related to T1410

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/119/ for more details.

Harbormaster completed remote builds in B19284: Diff 18183.Feb 17 2021, 1:27 PM
ardumont requested review of this revision.Feb 17 2021, 1:27 PM
anlambert added a subscriber: anlambert.Feb 17 2021, 5:47 PM

Looks good to me !

swh/loader/svn/tasks.py
15–16

I guess this can be removed.

anlambert accepted this revision.Feb 17 2021, 5:47 PM
This revision is now accepted and ready to land.Feb 17 2021, 5:47 PM
ardumont added inline comments.Feb 17 2021, 6:06 PM
swh/loader/svn/tasks.py
15–16

i initially thought "no"

Then i realized you probably mean, it'd be trapped by the try except...

so maybe ;)

ardumont updated this revision to Diff 18211.Feb 17 2021, 6:08 PM

Rebase
Drop the unnecessary conditional on None values

swh-public-ci added a comment.Feb 17 2021, 6:10 PM

Build is green

Patch application report for D5076 (id=18211)

Could not rebase; Attempt merge onto 71e3b44784...

Updating 71e3b44..eead508
Fast-forward
 mypy.ini                            |   5 +-
 requirements-swh.txt                |   2 +-
 requirements.txt                    |   1 +
 swh/loader/svn/loader.py            | 126 ++++++++++++++++++++----------------
 swh/loader/svn/tasks.py             |  91 ++++++++++++++++++--------
 swh/loader/svn/tests/conftest.py    |  44 +++++++------
 swh/loader/svn/tests/test_loader.py |  92 ++++++++++++++------------
 7 files changed, 213 insertions(+), 148 deletions(-)
Changes applied before test
commit eead508f0afe2d4793fbc2199c6832008f889104
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Sun Feb 7 08:55:36 2021 +0100

    loader: Expect visit_date as an optional date in constructors
    
    This avoids side-effect in the constructor and also aligns how it's done in other
    loaders (e.g git).
    
    Related to T1410

commit 2c54129bcf4864537d8d13d6645ef777fc1186ef
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Sun Feb 7 08:45:16 2021 +0100

    Rework loader instantiation logic according to loader core api
    
    Note that this also updated some docstrings and type along the way.
    
    Related to T1410

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/121/ for more details.

Harbormaster completed remote builds in B19309: Diff 18211.Feb 17 2021, 6:10 PM
Closed by commit rDLDSVNeead508f0afe: loader: Expect visit_date as an optional date in constructors (authored by ardumont). · Explain WhyFeb 17 2021, 6:19 PM
This revision was automatically updated to reflect the committed changes.
ardumont added a commit: rDLDSVNeead508f0afe: loader: Expect visit_date as an optional date in constructors.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
swh/
loader/
svn/
14 lines84%
Loading...
15 lines100%
Loading...

Diff 18211

View Options

swh/loader/svn/loader.py

Loading...
View Options

swh/loader/svn/tasks.py

Loading...
About · Developer information · Legal