Differential D5042

loader.svn: Explicit the failure test cases
ClosedPublic
Actions

Authored by ardumont on Feb 8 2021, 7:07 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T3030: Improve loaders to deal with new visit status events

Commits

rDLDSVNddc18d085147: svn.loader: Mark visit status as failed

Summary

With the new loader.core 0.17, failed or partial status changed slightly.
This adds the necessary tests to explicit those.

Related to T3030

Test Plan

tox
(failing until swh.loader.core > 0.16 release)

Diff Detail

Repository

rDLDG Git loader

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 19104
Build 29624: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 29623: arc lint + arc unit

Event Timeline

ardumont created this revision.Feb 8 2021, 7:07 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 8 2021, 7:07 PM

Build has FAILED

Patch application report for D5042 (id=17983)

Rebasing onto 824880e7d7...

Current branch diff-target is up to date.

Changes applied before test

commit f65fde77a942476de8173bb70c7eef9717bbffb0
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Feb 8 19:07:04 2021 +0100

    loader.git: Explicit the failure test cases
    
    Related to T3030

Link to build: https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/75/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/75/console

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 8 2021, 7:08 PM

Harbormaster failed remote builds in B19104: Diff 17983!

Explicit commit message (and trigger back the build which should go green since the new
loader-core got released)

Build is green

Patch application report for D5042 (id=18055)

Rebasing onto 220678c753...

Current branch diff-target is up to date.

Changes applied before test

commit ddc18d08514725fe7fb59857c8181e2cdaa47e3e
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Feb 8 17:36:57 2021 +0100

    svn.loader: Mark visit status as failed
    
    With the latest swh.loader.core 0.17, a partial without without snapshot is failed.
    
    Related to T3030

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/107/ for more details.

Harbormaster completed remote builds in B19167: Diff 18055.Feb 11 2021, 12:07 PM

ardumont requested review of this revision.Feb 11 2021, 12:07 PM

ardumont edited the summary of this revision. (Show Details)Feb 11 2021, 12:10 PM

vlorentz accepted this revision.Feb 11 2021, 1:14 PM

vlorentz retitled this revision from loader.git: Explicit the failure test cases to loader.svn: Explicit the failure test cases.

This revision is now accepted and ready to land.Feb 11 2021, 1:14 PM

Closed by commit rDLDSVNddc18d085147: svn.loader: Mark visit status as failed (authored by ardumont). · Explain WhyFeb 11 2021, 2:32 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDLDSVNddc18d085147: svn.loader: Mark visit status as failed.