Differential D4967

launchpad: Remove call to dataclasses.asdict on lister state
ClosedPublic
Actions

Authored by anlambert on Jan 28 2021, 7:18 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T3003: next gen lister: Make lister flush their visit state regularly

Commits

rDLS5aa7c8f2b21f: launchpad: Remove call to dataclasses.asdict on lister state

Summary

This generates an error due to the datetime type field, so manually build
the dict instead.

Related to T3003#57551

Diff Detail

Repository

rDLS Listers

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 18868
Build 29232: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 29231: arc lint + arc unit

Event Timeline

anlambert created this revision.Jan 28 2021, 7:18 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 28 2021, 7:18 PM

Build is green

Patch application report for D4967 (id=17727)

Rebasing onto 46f5a50099...

Current branch diff-target is up to date.

Changes applied before test

commit 5aa7c8f2b21f78d32c70dee8d90076452bb712cc
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Jan 28 19:15:58 2021 +0100

    launchpad: Remove call to dataclasses.asdict on lister state
    
    This generates an error due to the datetime type field, so manually build
    the dict instead.
    
    Related to T3003#57551

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/224/ for more details.

Harbormaster completed remote builds in B18868: Diff 17727.Jan 28 2021, 7:21 PM

anlambert requested review of this revision.Jan 28 2021, 7:21 PM

ardumont accepted this revision.Jan 28 2021, 7:22 PM

This revision is now accepted and ready to land.Jan 28 2021, 7:22 PM

Closed by commit rDLS5aa7c8f2b21f: launchpad: Remove call to dataclasses.asdict on lister state (authored by anlambert). · Explain WhyJan 28 2021, 7:26 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDLS5aa7c8f2b21f: launchpad: Remove call to dataclasses.asdict on lister state.