Differential D4958

cli: Make cli work with new lister...
ClosedPublic
Actions

Authored by ardumont on Jan 27 2021, 6:38 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDLS17b0e7af260c: cli: Make cli work with new lister

Summary

... while allowing legacy lister to still run (with --legacy)

Diff Detail

Repository

rDLS Listers

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 18827
Build 29163: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 29162: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	68 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.lister.gitlab.tests.test_lister::test_lister_gitlab_url_computation swh_scheduler = <swh.scheduler.backend.SchedulerBackend object at 0x7f53a4bb73c8> def test_lister_gitlab_url_computation(swh_scheduler):
	286 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.lister.bitbucket.tests.test_lister::test_bitbucket_full_lister
	400 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.lister.bitbucket.tests.test_lister::test_bitbucket_incremental_lister
	275 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.lister.bitbucket.tests.test_lister::test_bitbucket_lister_rate_limit_hit
	771 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.lister.bitbucket.tests.test_tasks::test_full_listing
		View Full Test Results (1 Failed · 133 Passed)

Event Timeline

ardumont created this revision.Jan 27 2021, 6:38 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 27 2021, 6:38 PM

Build is green

Patch application report for D4958 (id=17683)

Could not rebase; Attempt merge onto cbd2cce339...

Updating cbd2cce..b5160b8
Fast-forward
 swh/lister/cli.py                      |  8 +++++---
 swh/lister/gitlab/lister.py            |  6 +++++-
 swh/lister/gitlab/tests/test_lister.py | 10 ++++++++++
 3 files changed, 20 insertions(+), 4 deletions(-)

Changes applied before test

commit b5160b8a3692b271d3c6583bea4d855aa70cc880
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jan 27 18:28:09 2021 +0100

    cli: Make cli work with new lister
    
    while allowing legacy lister to still run (with --legacy)

commit 2065fb167d07b072c87d739c23f9f2c645d97fd0
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jan 27 18:02:08 2021 +0100

    gitlab: Allow sysadm to forget the trailing /

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/204/ for more details.

Harbormaster completed remote builds in B18824: Diff 17683.Jan 27 2021, 6:44 PM

ardumont requested review of this revision.Jan 27 2021, 6:44 PM

anlambert accepted this revision.Jan 27 2021, 6:46 PM

This revision is now accepted and ready to land.Jan 27 2021, 6:46 PM

Legacy option should be removed soon so no tests needed here ;-)

Rebase

(for the test and the soon to be adapted, yes, my thoughts exactly ;)

Build has FAILED

Patch application report for D4958 (id=17686)

Could not rebase; Attempt merge onto cbd2cce339...

Updating cbd2cce..40ef654
Fast-forward
 swh/lister/cli.py                      |  8 +++++---
 swh/lister/gitlab/lister.py            |  7 +++++--
 swh/lister/gitlab/tests/test_lister.py | 10 ++++++++++
 3 files changed, 20 insertions(+), 5 deletions(-)

Changes applied before test

commit 40ef654f6d7b8b079072d8af83a3593d9444edd3
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jan 27 18:28:09 2021 +0100

    cli: Make cli work with new lister
    
    while allowing legacy lister to still run (with --legacy)

commit 260c825953f6b5fe483d1cd408f86effe55ab71d
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jan 27 18:02:08 2021 +0100

    gitlab: Deal with missing or trailing / in url input

Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/206/
See console output for more information: https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/206/console

Harbormaster failed remote builds in B18827: Diff 17686!Jan 27 2021, 7:13 PM

Rebase

Build is green

Patch application report for D4958 (id=17687)

Rebasing onto cbd2cce339...

Current branch diff-target is up to date.

Changes applied before test

commit 17b0e7af260c942093ac5d0c49e5f13ea7d9ed96
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jan 27 18:28:09 2021 +0100

    cli: Make cli work with new lister
    
    while allowing legacy lister to still run (with --legacy)

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/207/ for more details.

Harbormaster completed remote builds in B18828: Diff 17687.Jan 28 2021, 9:16 AM

Closed by commit rDLS17b0e7af260c: cli: Make cli work with new lister (authored by ardumont). · Explain WhyJan 28 2021, 9:20 AM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDLS17b0e7af260c: cli: Make cli work with new lister.