Page MenuHomeSoftware Heritage
Differential D4944

gitlab: Add support for last_update information during listing
ClosedPublic
Actions

Authored by ardumont on Jan 25 2021, 6:33 PM.

Details

Reviewers
anlambert
Group Reviewers
Reviewers
Commits
rDLSaefb260f76bf: gitlab: Add support for last_update information during listing
Summary

Is it enough?

Diff Detail

Repository
rDLS Listers
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18733
Build 28996: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 28995: arc lint + arc unit

Unit TestsFailed
View All

TimeTest
368 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.lister.gitlab.tests.test_lister::test_lister_gitlab
datadir = '/var/lib/jenkins/workspace/DLS/tests-on-diff/.tox/py3/lib/python3.7/site-packages/swh/lister/gitlab/tests/data' swh_scheduler = <swh.scheduler.backend.SchedulerBackend object at 0x7eff721b9f60> requests_mock = <requests_mock.mocker.Mocker object at 0x7eff703f6b38>
172 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.lister.gitlab.tests.test_lister::test_lister_gitlab_incremental
swh_scheduler = <swh.scheduler.backend.SchedulerBackend object at 0x7eff70442630> requests_mock = <requests_mock.mocker.Mocker object at 0x7eff70442da0> datadir = '/var/lib/jenkins/workspace/DLS/tests-on-diff/.tox/py3/lib/python3.7/site-packages/swh/lister/gitlab/tests/data'
368 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.lister.gitlab.tests.test_lister::test_lister_gitlab_rate_limit
swh_scheduler = <swh.scheduler.backend.SchedulerBackend object at 0x7eff70dc66a0> requests_mock = <requests_mock.mocker.Mocker object at 0x7eff70dc6eb8> datadir = '/var/lib/jenkins/workspace/DLS/tests-on-diff/.tox/py3/lib/python3.7/site-packages/swh/lister/gitlab/tests/data'
167 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.lister.gitlab.tests.test_lister::test_lister_gitlab_with_pages
swh_scheduler = <swh.scheduler.backend.SchedulerBackend object at 0x7eff7123ed68> requests_mock = <requests_mock.mocker.Mocker object at 0x7eff7047da90> datadir = '/var/lib/jenkins/workspace/DLS/tests-on-diff/.tox/py3/lib/python3.7/site-packages/swh/lister/gitlab/tests/data'
1,412 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.lister.tests.test_cli::test_get_lister
swh_scheduler_config = {'db': "dbname=scheduler user=postgres host=127.0.0.1 port=30237 options=''"} def test_get_lister(swh_scheduler_config):
View Full Test Results (5 Failed · 126 Passed)

Event Timeline

ardumont created this revision.Jan 25 2021, 6:33 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJan 25 2021, 6:33 PM
swh-public-ci added a comment.Jan 25 2021, 6:39 PM

Build has FAILED

Patch application report for D4944 (id=17595)

Could not rebase; Attempt merge onto ea8ecee541...

Updating ea8ecee..cda5d43
Fast-forward
 swh/lister/gitlab/lister.py            | 23 ++++++++++++++++-------
 swh/lister/gitlab/tests/test_lister.py | 13 +++++++++++++
 2 files changed, 29 insertions(+), 7 deletions(-)
Changes applied before test
commit cda5d4389c49e28355819a87df2e4c8003fd8911
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jan 25 18:33:32 2021 +0100

    gitlab: Add last_update information support

commit 0c9cbe833920bbc358df54de6a86cb79da4d47e6
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jan 25 18:15:21 2021 +0100

    gitlab: make url mandatory and add type

commit f49af7a3b03985eeef63639e78fab76bb8db6f6b
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jan 25 15:32:49 2021 +0100

    gitlab: Support authentication
    
    Related to T2987

Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/166/
See console output for more information: https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/166/console

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 25 2021, 6:39 PM
Harbormaster failed remote builds in B18733: Diff 17595!
ardumont updated this revision to Diff 17597.Jan 25 2021, 6:40 PM

Rebase

ardumont edited the summary of this revision. (Show Details)Jan 25 2021, 6:41 PM
swh-public-ci added a comment.Jan 25 2021, 6:44 PM

Build has FAILED

Patch application report for D4944 (id=17597)

Could not rebase; Attempt merge onto ea8ecee541...

Updating ea8ecee..4992bab
Fast-forward
 swh/lister/gitlab/lister.py            | 21 +++++++++++++++------
 swh/lister/gitlab/tests/test_lister.py | 13 +++++++++++++
 2 files changed, 28 insertions(+), 6 deletions(-)
Changes applied before test
commit 4992bab23ccc9587a56bc2096fa1a924574938c5
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jan 25 18:33:32 2021 +0100

    gitlab: Add last_update information support

commit f49af7a3b03985eeef63639e78fab76bb8db6f6b
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jan 25 15:32:49 2021 +0100

    gitlab: Support authentication
    
    Related to T2987

Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/168/
See console output for more information: https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/168/console

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 25 2021, 6:44 PM
Harbormaster failed remote builds in B18735: Diff 17597!
ardumont updated this revision to Diff 17601.Jan 25 2021, 7:08 PM

Parse field as iso8601 date

ardumont retitled this revision from gitlab: Add last_update information support to gitlab: Add support for last_update information during listing.Jan 25 2021, 7:09 PM
swh-public-ci added a comment.Jan 25 2021, 7:11 PM

Build is green

Patch application report for D4944 (id=17601)

Could not rebase; Attempt merge onto bea9d6d147...

Updating bea9d6d..92abe47
Fast-forward
 swh/lister/gitlab/lister.py            | 22 ++++++++++++++++------
 swh/lister/gitlab/tests/test_lister.py | 13 +++++++++++++
 2 files changed, 29 insertions(+), 6 deletions(-)
Changes applied before test
commit 92abe47b5f425edc7309222bb23eebbabf9de8b4
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jan 25 18:33:32 2021 +0100

    gitlab: Add support for last_update information during listing

commit 544a38f109ac89fc6d1b5222ae5324539e350798
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jan 25 15:32:49 2021 +0100

    gitlab: Support authentication
    
    Related to T2987

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/171/ for more details.

Harbormaster completed remote builds in B18740: Diff 17601.Jan 25 2021, 7:11 PM
ardumont requested review of this revision.Jan 25 2021, 7:11 PM
anlambert accepted this revision.Jan 25 2021, 7:28 PM
anlambert added a subscriber: anlambert.

You should add a test to check the last_update field value in scheduler database is not None.

This revision is now accepted and ready to land.Jan 25 2021, 7:28 PM
ardumont updated this revision to Diff 17617.Jan 26 2021, 2:06 PM

address suggestion, ensure last_update field in listed_origin are not None

swh-public-ci added a comment.Jan 26 2021, 2:12 PM

Build is green

Patch application report for D4944 (id=17617)

Could not rebase; Attempt merge onto bea9d6d147...

Updating bea9d6d..aefb260
Fast-forward
 swh/lister/gitlab/lister.py            | 19 +++++++++++++------
 swh/lister/gitlab/tests/test_lister.py | 18 ++++++++++++++++++
 2 files changed, 31 insertions(+), 6 deletions(-)
Changes applied before test
commit aefb260f76bf2f1abe37b638a30c9ba7386751c4
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jan 25 18:33:32 2021 +0100

    gitlab: Add support for last_update information during listing

commit 1a19b2c74752a0a77539aaab1763340e8cef31a0
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jan 25 15:32:49 2021 +0100

    gitlab: Support authentication
    
    Related to T2987

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/175/ for more details.

Harbormaster completed remote builds in B18755: Diff 17617.Jan 26 2021, 2:12 PM
Closed by commit rDLSaefb260f76bf: gitlab: Add support for last_update information during listing (authored by ardumont). · Explain WhyJan 26 2021, 3:02 PM
This revision was automatically updated to reflect the committed changes.
ardumont added a commit: rDLSaefb260f76bf: gitlab: Add support for last_update information during listing.

Revision Contents
Changeset List

PathSize
swh/
lister/
gitlab/
3 lines

Diff 17595

View Options

swh/lister/gitlab/lister.py

Loading...
About · Developer information · Legal