Page MenuHomeSoftware Heritage

Run Black.
ClosedPublic

Authored by vlorentz on Jan 21 2021, 12:05 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDSCHaf3789891f1e: Run Black.
Summary

It wasn't ran on d464b4cc1f9ae6a5c5c94a534826eff5cc27f12f.

Diff Detail

Repository
rDSCH Scheduling utilities
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18599
Build 28766: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 28765: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D4902 (id=17463)

Rebasing onto b641ac83eb...

Current branch diff-target is up to date.
Changes applied before test
commit af3789891f1e834a5e7a5b9f29b6a5596056fb7d
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Jan 21 12:04:55 2021 +0100

    Run Black.
    
    It wasn't ran on d464b4cc1f9ae6a5c5c94a534826eff5cc27f12f.

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/217/ for more details.

ardumont added a subscriber: ardumont.

Thanks.

As for the reason:

12:07 <+ardumont> why it was not formatted, might be because of the rebase
12:08 <+ardumont> the `git commit` now feels slugish since we started using pre-commit
12:08 <+ardumont> but the rebase in themselves are not
12:08 <+ardumont> so i don't think pre-commit is run during those
12:10 <+ardumont> and i did the last rebase actually focusing on the stability not the formatting so there you go, that must be how it passed through
12:10 <+olasd> git hooks don't fire on rebase
This revision is now accepted and ready to land.Jan 21 2021, 12:11 PM
This revision was automatically updated to reflect the committed changes.