Differential D4878

Remove the deprecated external_identifer from metadata
ClosedPublic
Actions

Authored by vsellier on Jan 19 2021, 7:44 AM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T2976: Deposit tests end-to-end are failing in icinga

Commits

rDICP36f52101f078: Remove the deprecated external_identifer from metadata

Summary

Since the v0.9.2 of the deposit, the external_identifier is deprecated
and if it's specified it must be equals to the slug.

Related to T2976

Diff Detail

Repository

rDICP Icinga plugins

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 18458
Build 28539: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 28538: arc lint + arc unit

Event Timeline

vsellier created this revision.Jan 19 2021, 7:44 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 19 2021, 7:44 AM

Build is green

Patch application report for D4878 (id=17319)

Rebasing onto d7a171c3e4...

Current branch diff-target is up to date.

Changes applied before test

commit 36f52101f0788e080aa35f986d9c2e778e80d91e
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date:   Tue Jan 19 07:33:03 2021 +0100

    Remove the deprecated external_identifer from metadata
    
    Since the v0.9.2 of the deposit, the external_identifier is deprecated
    and if it's specified it must be equals to the slug.
    
    Related to T2976

See https://jenkins.softwareheritage.org/job/DICP/job/tests-on-diff/18/ for more details.

Harbormaster completed remote builds in B18458: Diff 17319.Jan 19 2021, 7:45 AM

vsellier requested review of this revision.Jan 19 2021, 7:45 AM

ardumont accepted this revision.Jan 19 2021, 9:24 AM

This revision is now accepted and ready to land.Jan 19 2021, 9:24 AM

Thanks

Closed by commit rDICP36f52101f078: Remove the deprecated external_identifer from metadata (authored by vsellier). · Explain WhyJan 19 2021, 10:57 AM

This revision was automatically updated to reflect the committed changes.

vsellier added a commit: rDICP36f52101f078: Remove the deprecated external_identifer from metadata.