Differential D4871

Backfiller: Add type to the origin_visit_status topic
ClosedPublic
Actions

Authored by vsellier on Jan 15 2021, 2:41 PM.

Details

Reviewers

olasd

Group Reviewers

Reviewers

Maniphest Tasks

T2966: Backfill origin_visit_status **with** the `visit_type` field properly given

Commits

rDSTOd04165f5b458: Add type to the origin_visit_status topic

Summary

useful when the type is not yet populated in the database

Related to T2966

Test Plan

tox

Diff Detail

Repository

rDSTO Storage manager

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 18413
Build 28460: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 28459: arc lint + arc unit

Event Timeline

vsellier created this revision.Jan 15 2021, 2:41 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 15 2021, 2:41 PM

Build is green

Patch application report for D4871 (id=17273)

Rebasing onto c24d35f86a...

Current branch diff-target is up to date.

Changes applied before test

commit 95ac7ac8464e1474881c7969e19bd6d0c9e0e10f
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date:   Fri Jan 15 14:35:12 2021 +0100

    Add type to the origin_visit_status topic
    
    useful when the type is not yet populated in the database
    
    Related to T2966

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1104/ for more details.

Harbormaster completed remote builds in B18413: Diff 17273.Jan 15 2021, 2:46 PM

vsellier requested review of this revision.Jan 15 2021, 2:46 PM

ardumont retitled this revision from Add type to the origin_visit_status topic to Backfiller: Add type to the origin_visit_status topic.Jan 15 2021, 5:02 PM

I guess the SQL can be simplified a bit but this looks fine.

swh/storage/backfill.py
170–171

This revision is now accepted and ready to land.Jan 18 2021, 11:31 AM

Rework the sql query to use the "using" keyword to join

vsellier added inline comments.Jan 18 2021, 11:51 AM

swh/storage/backfill.py
170–171	thanks, indeed, it's a lot more readable

Build is green

Patch application report for D4871 (id=17299)

Rebasing onto c24d35f86a...

Current branch diff-target is up to date.

Changes applied before test

commit d04165f5b458a69ed89389b192f105652fed4972
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date:   Fri Jan 15 14:35:12 2021 +0100

    Add type to the origin_visit_status topic
    
    useful when the type is not yet populated in the database
    
    Related to T2966

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1105/ for more details.

Harbormaster completed remote builds in B18438: Diff 17299.Jan 18 2021, 11:55 AM

Closed by commit rDSTOd04165f5b458: Add type to the origin_visit_status topic (authored by vsellier). · Explain WhyJan 18 2021, 12:01 PM

This revision was automatically updated to reflect the committed changes.

vsellier added a commit: rDSTOd04165f5b458: Add type to the origin_visit_status topic.