Differential D4820

config: sane default for batch_size using a heuristic on ram size
ClosedPublic
Actions

Authored by seirl on Jan 7 2021, 5:43 PM.

Details

Reviewers

zack

Maniphest Tasks

T2595: Add a default configuration based on graph size (eg: batch_size)

Commits

rDGRPH5a987aae6e93: config: sane default for batch_size using a heuristic on ram size

Diff Detail

Repository

rDGRPH Compressed graph representation

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 18236
Build 28147: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 28146: arc lint + arc unit

Event Timeline

seirl created this revision.Jan 7 2021, 5:43 PM

Build is green

Patch application report for D4820 (id=17074)

Rebasing onto 07a8f25eae...

Current branch diff-target is up to date.

Changes applied before test

commit bcc0e1e5a41249cfd6fd428fcda8aac36b19a51f
Author: Antoine Pietri <antoine.pietri1@gmail.com>
Date:   Thu Jan 7 17:42:39 2021 +0100

    config: sane default for batch_size using a heuristic on ram size

See https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/61/ for more details.

Harbormaster completed remote builds in B18216: Diff 17074.Jan 7 2021, 5:45 PM

seirl requested review of this revision.Jan 7 2021, 5:45 PM

note that this diff should close T2595, so the commit message should be updated

This revision is now accepted and ready to land.Jan 7 2021, 10:33 PM

zack added a task: T2595: Add a default configuration based on graph size (eg: batch_size).Jan 7 2021, 10:34 PM

Add task name to commit message

rebase

Build is green

Patch application report for D4820 (id=17092)

Rebasing onto 85da2e78d6...

First, rewinding head to replay your work on top of it...
Applying: config: sane default for batch_size using a heuristic on ram size

Changes applied before test

commit a1f90b6112a5f55737480fa2ec34d718fc483d03
Author: Antoine Pietri <antoine.pietri1@gmail.com>
Date:   Thu Jan 7 17:42:39 2021 +0100

    config: sane default for batch_size using a heuristic on ram size
    
    Fix T2595

See https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/63/ for more details.

Harbormaster completed remote builds in B18235: Diff 17092.Jan 8 2021, 3:25 PM

Build is green

Patch application report for D4820 (id=17093)

Rebasing onto 85da2e78d6...

Current branch diff-target is up to date.

Changes applied before test

commit 5a987aae6e936b73c554d025897f79214969a739
Author: Antoine Pietri <antoine.pietri1@gmail.com>
Date:   Thu Jan 7 17:42:39 2021 +0100

    config: sane default for batch_size using a heuristic on ram size
    
    Fix T2595

See https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/64/ for more details.

Harbormaster completed remote builds in B18236: Diff 17093.Jan 8 2021, 3:27 PM

Closed by commit rDGRPH5a987aae6e93: config: sane default for batch_size using a heuristic on ram size (authored by seirl). · Explain WhyJan 8 2021, 3:27 PM

This revision was automatically updated to reflect the committed changes.

seirl added a commit: rDGRPH5a987aae6e93: config: sane default for batch_size using a heuristic on ram size.