Differential D4812

tests: Fix test_gen_swhid after swh-model update
ClosedPublic
Actions

Authored by anlambert on Jan 6 2021, 11:19 AM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDWAPPS74fb38319f6b: tests: Fix test_gen_swhid after swh-model update

Summary

FAILED swh/web/tests/common/test_identifiers.py::test_gen_swhid - swh.web.common.exc.BadInputExc: Invalid object (fa1639c32dc0dab56544a6534642065c8241373e) for SWHID. ['Invalid SWHID: unknown qualifier: foo']

Diff Detail

Repository

rDWAPPS Web applications

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 18188
Build 28073: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 28072: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	0 ms	Jenkins > should close calendar popover when leaving day::Tests / Cypress tests / Run cypress tests / Visits tests should close calendar popover when leaving day CypressError: Timed out retrying: `cy.trigger()` failed because this element: `<div class="day-content">...</div>`
	224 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.admin.test_origin_save::Tests / Python tests / test_accept_pending_save_request
	781 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.admin.test_origin_save::Tests / Python tests / test_add_authorized_origin_url
	119 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.admin.test_origin_save::Tests / Python tests / test_add_unauthorized_origin_url
	130 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.admin.test_origin_save::Tests / Python tests / test_reject_pending_save_request
		View Full Test Results (1 Failed · 625 Passed · 5 Skipped)

Event Timeline

anlambert created this revision.Jan 6 2021, 11:19 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 6 2021, 11:19 AM

Build has FAILED

Patch application report for D4812 (id=17047)

Rebasing onto 6499c518d0...

Current branch diff-target is up to date.

Changes applied before test

commit 529e9317317f7c812a829dd1900b7097548d516c
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Jan 6 11:17:57 2021 +0100

    tests: Fix test_gen_swhid after swh-model update

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/540/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/540/console

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 6 2021, 11:26 AM

Harbormaster failed remote builds in B18188: Diff 17047!

Build has FAILED

Patch application report for D4812 (id=17047)

Rebasing onto 6499c518d0...

Current branch diff-target is up to date.

Changes applied before test

commit 529e9317317f7c812a829dd1900b7097548d516c
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Jan 6 11:17:57 2021 +0100

    tests: Fix test_gen_swhid after swh-model update

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/541/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/541/console

Rebase

Build is green

Patch application report for D4812 (id=17053)

Rebasing onto be64d903f7...

Current branch diff-target is up to date.

Changes applied before test

commit 74fb38319f6bcfb214425c1d93fef6a8e70dd058
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Jan 6 11:17:57 2021 +0100

    tests: Fix test_gen_swhid after swh-model update

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/543/ for more details.

Harbormaster completed remote builds in B18194: Diff 17053.Jan 6 2021, 1:32 PM

anlambert requested review of this revision.Jan 6 2021, 1:32 PM

ardumont accepted this revision.Jan 6 2021, 1:48 PM

This revision is now accepted and ready to land.Jan 6 2021, 1:48 PM

Closed by commit rDWAPPS74fb38319f6b: tests: Fix test_gen_swhid after swh-model update (authored by anlambert). · Explain WhyJan 6 2021, 2:10 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS74fb38319f6b: tests: Fix test_gen_swhid after swh-model update.