Differential D4557

from_disk: Fix mypy error with dulwich >= 0.20.13
ClosedPublic
Actions

Authored by anlambert on Nov 23 2020, 1:31 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDLDG2c311b0e6dbb: from_disk: Fix mypy error with dulwich >= 0.20.13

Summary

dulwich recently adds PEP-561 compatibility [1] so ignore typecheck for older
dulwich versions.

[1] https://github.com/dulwich/dulwich/commit/e116a6eb05598eb59c3e3d2239f6fcd13a1e25e3

Diff Detail

Repository

rDLDG Git loader

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 17394
Build 26874: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 26873: arc lint + arc unit

Event Timeline

anlambert created this revision.Nov 23 2020, 1:31 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 23 2020, 1:31 PM

Build is green

Patch application report for D4557 (id=16194)

Rebasing onto 9ad25545de...

Current branch diff-target is up to date.

Changes applied before test

commit 2c311b0e6dbbc863f740032a072668cab2449221
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Mon Nov 23 13:29:58 2020 +0100

    from_disk: Fix mypy error with dulwich >= 0.20.13
    
    dulwich recently adds PEP-561 compatibility so ignore typecheck for older
    dulwich versions.

See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/71/ for more details.

Harbormaster completed remote builds in B17394: Diff 16194.Nov 23 2020, 1:32 PM

ardumont accepted this revision.Nov 23 2020, 1:32 PM

This revision is now accepted and ready to land.Nov 23 2020, 1:32 PM

Closed by commit rDLDG2c311b0e6dbb: from_disk: Fix mypy error with dulwich >= 0.20.13 (authored by anlambert). · Explain WhyNov 23 2020, 1:33 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDLDG2c311b0e6dbb: from_disk: Fix mypy error with dulwich >= 0.20.13.