Page MenuHomeSoftware Heritage
Differential D4373

common/origin_save: Get more accurate scheduler task termination status
ClosedPublic
Actions

Authored by anlambert on Oct 28 2020, 3:12 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Maniphest Tasks
T2658: Failed save code now request reported as succeded
Commits
rDWAPPSd6aeb71affe7: common/origin_save: Get more accurate scheduler task termination status
Summary

Use termination statuses returned by scheduler.get_task_runs to get more
accurate save origin requests reporting regarding their execution states.

Closes T2658

Diff Detail

Repository
rDWAPPS Web applications
Branch
origin-save-improve-task-status-reporting
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16769
Build 25859: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 25858: arc lint + arc unit

Event Timeline

anlambert created this revision.Oct 28 2020, 3:12 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptOct 28 2020, 3:12 PM
swh-public-ci added a comment.Oct 28 2020, 3:19 PM

Build is green

Patch application report for D4373 (id=15475)

Rebasing onto 3ffeb396fa...

Current branch diff-target is up to date.
Changes applied before test
commit 8f146d331a6953f572c9d434aae893207d6ca97b
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Oct 28 15:08:33 2020 +0100

    common/origin_save: Get more accurate scheduler task termination status
    
    Use termination statuses returned by scheduler.get_task_runs to get more
    accurate save origin requests reporting regarding their execution states.
    
    Closes T2658

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/441/ for more details.

Harbormaster completed remote builds in B16701: Diff 15475.Oct 28 2020, 3:19 PM
ardumont added a subscriber: ardumont.Oct 30 2020, 3:34 PM

lgtm

anlambert updated this revision to Diff 15536.Oct 30 2020, 3:39 PM

Rebase

swh-public-ci added a comment.Oct 30 2020, 3:40 PM

Build has FAILED

Patch application report for D4373 (id=15536)

Rebasing onto f6cb156178...

Current branch diff-target is up to date.
Changes applied before test
commit a49802a6ad2763c675f712d2fc9829b30bba52af
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Oct 28 15:08:33 2020 +0100

    common/origin_save: Get more accurate scheduler task termination status
    
    Use termination statuses returned by scheduler.get_task_runs to get more
    accurate save origin requests reporting regarding their execution states.
    
    Closes T2658

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/444/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/444/console

Harbormaster failed remote builds in B16762: Diff 15536!Oct 30 2020, 3:40 PM
ardumont accepted this revision.Oct 30 2020, 4:03 PM
This revision is now accepted and ready to land.Oct 30 2020, 4:03 PM
anlambert updated this revision to Diff 15543.Oct 30 2020, 4:08 PM

Rebase

swh-public-ci added a comment.Oct 30 2020, 4:15 PM

Build is green

Patch application report for D4373 (id=15543)

Rebasing onto b51ca62ef3...

Current branch diff-target is up to date.
Changes applied before test
commit d6aeb71affe7c81d7b5d53c8f240eab6cc1a1772
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Oct 28 15:08:33 2020 +0100

    common/origin_save: Get more accurate scheduler task termination status
    
    Use termination statuses returned by scheduler.get_task_runs to get more
    accurate save origin requests reporting regarding their execution states.
    
    Closes T2658

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/446/ for more details.

Harbormaster completed remote builds in B16769: Diff 15543.Oct 30 2020, 4:15 PM
Closed by commit rDWAPPSd6aeb71affe7: common/origin_save: Get more accurate scheduler task termination status (authored by anlambert). · Explain WhyOct 30 2020, 4:22 PM
This revision was automatically updated to reflect the committed changes.
anlambert added a commit: rDWAPPSd6aeb71affe7: common/origin_save: Get more accurate scheduler task termination status.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
swh/
web/
common/
26 lines93%
Loading...
tests/
api/
views/
117 lines100%
Loading...
common/
44 lines100%
Loading...

Diff 15543

View Options

swh/web/common/origin_save.py

Show All 26 Lines cy.route({
} }
}); });
// the tested UI should not be accessible for standard Django users // the tested UI should not be accessible for standard Django users
// but we need a user logged in for testing it // but we need a user logged in for testing it
cy.adminLogin(); cy.adminLogin();
cy.visit(`${Urls.oidc_profile()}#tokens`); cy.visit(`${Urls.oidc_profile()}#tokens`);
} }
function generateToken(Urls, status, tokenValue = '') { it('should initiate token generation flow', function() {
cy.route({ initTokensPage(this.Urls, []);
method: 'POST',
url: `${Urls.oidc_generate_bearer_token()}/**`,
response: tokenValue,
status: status
}).as('generateTokenRequest');
cy.contains('Generate new token') cy.contains('Generate new token')
.click(); .click();
cy.get('.modal-dialog') cy.get('.modal-dialog')
.should('be.visible'); .should('be.visible');
cy.get('.modal-header') cy.get('.modal-header')
.should('contain', 'Bearer token generation'); .should('contain', 'Bearer token generation');
cy.get('#swh-user-password-submit') cy.get('#swh-token-form-submit')
.should('be.disabled');
cy.get('#swh-user-password')
.type('secret');
cy.get('#swh-user-password-submit')
.should('be.enabled');
cy.get('#swh-user-password-submit')
.click(); .click();
cy.wait('@generateTokenRequest'); cy.location().should(loc => {
expect(loc.pathname).to.eq(this.Urls.oidc_generate_bearer_token());
if (status === 200) { });
cy.get('#swh-user-password-submit')
.should('be.disabled');
}
}
it('should generate and display bearer token', function() {
initTokensPage(this.Urls, []);
const tokenValue = 'bearer-token-value';
generateToken(this.Urls, 200, tokenValue);
cy.get('#swh-token-success-message')
.should('contain', 'Below is your token');
cy.get('#swh-bearer-token')
.should('contain', tokenValue);
}); });
it('should report errors when token generation failed', function() { it('should report error when not logged in and visiting a token generation URL', function() {
initTokensPage(this.Urls, []); cy.visit(this.Urls.oidc_generate_bearer_token_complete(), {failOnStatusCode: false});
generateToken(this.Urls, 400); cy.get('.swh-http-error')
cy.get('#swh-token-error-message') .should('be.visible');
cy.get('.swh-http-error-code')
.should('contain', 403);
cy.get('.swh-http-error-desc')
.should('contain', 'You are not allowed to generate bearer tokens'); .should('contain', 'You are not allowed to generate bearer tokens');
cy.get('#swh-web-modal-html .close').click();
generateToken(this.Urls, 401);
cy.get('#swh-token-error-message')
.should('contain', 'The password is invalid');
cy.get('#swh-web-modal-html .close').click();
generateToken(this.Urls, 500);
cy.get('#swh-token-error-message')
.should('contain', 'Internal server error');
}); });
function displayToken(Urls, status, tokenValue = '') { function displayToken(Urls, status, tokenValue = '') {
cy.route({ cy.route({
method: 'POST', method: 'POST',
url: `${Urls.oidc_get_bearer_token()}/**`, url: `${Urls.oidc_get_bearer_token()}/**`,
response: tokenValue, response: tokenValue,
status: status status: status
}).as('getTokenRequest'); }).as('getTokenRequest');
cy.contains('Display token') cy.contains('Display token')
.click({force: true}); .click({force: true});
cy.get('.modal-dialog') cy.get('.modal-dialog')
.should('be.visible'); .should('be.visible');
cy.get('.modal-header') cy.get('.modal-header')
.should('contain', 'Display bearer token'); .should('contain', 'Display bearer token');
cy.get('#swh-user-password-submit')
.should('be.disabled');
cy.get('#swh-user-password')
.type('secret', {force: true});
cy.get('#swh-user-password-submit')
.should('be.enabled');
cy.get('#swh-user-password-submit')
.click({force: true});
cy.wait('@getTokenRequest');
if (status === 200) {
cy.get('#swh-user-password-submit')
.should('be.disabled');
}
} }
it('should show a token when requested', function() { it('should show a token when requested', function() {
initTokensPage(this.Urls, [{id: 1, creation_date: new Date().toISOString()}]); initTokensPage(this.Urls, [{id: 1, creation_date: new Date().toISOString()}]);
const tokenValue = 'token-value'; const tokenValue = 'token-value';
displayToken(this.Urls, 200, tokenValue); displayToken(this.Urls, 200, tokenValue);
cy.get('#swh-token-success-message')
.should('contain', 'Below is your token');
cy.get('#swh-bearer-token') cy.get('#swh-bearer-token')
.should('contain', tokenValue); .should('contain', tokenValue);
}); });
it('should report errors when token display failed', function() { it('should report errors when token display failed', function() {
initTokensPage(this.Urls, [{id: 1, creation_date: new Date().toISOString()}]); initTokensPage(this.Urls, [{id: 1, creation_date: new Date().toISOString()}]);
displayToken(this.Urls, 401);
cy.get('#swh-token-error-message')
.should('contain', 'The password is invalid');
cy.get('#swh-web-modal-html .close').click();
displayToken(this.Urls, 500); displayToken(this.Urls, 500);
cy.get('#swh-token-error-message') cy.get('.modal-body')
.should('contain', 'Internal server error'); .should('contain', 'Internal server error');
}); });
function revokeToken(Urls, status) { function revokeToken(Urls, status) {
cy.route({ cy.route({
method: 'POST', method: 'POST',
url: `${Urls.oidc_revoke_bearer_tokens()}/**`, url: `${Urls.oidc_revoke_bearer_tokens()}/**`,
response: '', response: '',
status: status status: status
}).as('revokeTokenRequest'); }).as('revokeTokenRequest');
cy.contains('Revoke token') cy.contains('Revoke token')
.click({force: true}); .click({force: true});
cy.get('.modal-dialog') cy.get('.modal-dialog')
.should('be.visible'); .should('be.visible');
cy.get('.modal-header') cy.get('.modal-header')
.should('contain', 'Revoke bearer token'); .should('contain', 'Revoke bearer token');
cy.get('#swh-user-password-submit') cy.get('#swh-token-form-submit')
.should('be.disabled');
cy.get('#swh-user-password')
.type('secret', {force: true});
cy.get('#swh-user-password-submit')
.should('be.enabled');
cy.get('#swh-user-password-submit')
.click({force: true}); .click({force: true});
cy.wait('@revokeTokenRequest'); cy.wait('@revokeTokenRequest');
if (status === 200) { if (status === 200) {
cy.get('#swh-user-password-submit') cy.get('#swh-token-form-submit')
.should('be.disabled'); .should('be.disabled');
} }
} }
it('should revoke a token when requested', function() { it('should revoke a token when requested', function() {
initTokensPage(this.Urls, [{id: 1, creation_date: new Date().toISOString()}]); initTokensPage(this.Urls, [{id: 1, creation_date: new Date().toISOString()}]);
revokeToken(this.Urls, 200); revokeToken(this.Urls, 200);
cy.get('#swh-token-success-message') cy.get('#swh-token-form-message')
.should('contain', 'Bearer token successfully revoked'); .should('contain', 'Bearer token successfully revoked');
}); });
it('should report errors when token revoke failed', function() { it('should report errors when token revoke failed', function() {
initTokensPage(this.Urls, [{id: 1, creation_date: new Date().toISOString()}]); initTokensPage(this.Urls, [{id: 1, creation_date: new Date().toISOString()}]);
revokeToken(this.Urls, 401);
cy.get('#swh-token-error-message')
.should('contain', 'The password is invalid');
cy.get('#swh-web-modal-html .close').click();
revokeToken(this.Urls, 500); revokeToken(this.Urls, 500);
cy.get('#swh-token-error-message') cy.get('#swh-token-error-message')
.should('contain', 'Internal server error'); .should('contain', 'Internal server error');
}); });
}); });
View Options

swh/web/tests/api/views/test_origin_save.py

Show All 26 Lines cy.route({
} }
}); });
// the tested UI should not be accessible for standard Django users // the tested UI should not be accessible for standard Django users
// but we need a user logged in for testing it // but we need a user logged in for testing it
cy.adminLogin(); cy.adminLogin();
cy.visit(`${Urls.oidc_profile()}#tokens`); cy.visit(`${Urls.oidc_profile()}#tokens`);
} }
function generateToken(Urls, status, tokenValue = '') { it('should initiate token generation flow', function() {
cy.route({ initTokensPage(this.Urls, []);
method: 'POST',
url: `${Urls.oidc_generate_bearer_token()}/**`,
response: tokenValue,
status: status
}).as('generateTokenRequest');
cy.contains('Generate new token') cy.contains('Generate new token')
.click(); .click();
cy.get('.modal-dialog') cy.get('.modal-dialog')
.should('be.visible'); .should('be.visible');
cy.get('.modal-header') cy.get('.modal-header')
.should('contain', 'Bearer token generation'); .should('contain', 'Bearer token generation');
cy.get('#swh-user-password-submit') cy.get('#swh-token-form-submit')
.should('be.disabled');
cy.get('#swh-user-password')
.type('secret');
cy.get('#swh-user-password-submit')
.should('be.enabled');
cy.get('#swh-user-password-submit')
.click(); .click();
cy.wait('@generateTokenRequest'); cy.location().should(loc => {
expect(loc.pathname).to.eq(this.Urls.oidc_generate_bearer_token());
if (status === 200) { });
cy.get('#swh-user-password-submit')
.should('be.disabled');
}
}
it('should generate and display bearer token', function() {
initTokensPage(this.Urls, []);
const tokenValue = 'bearer-token-value';
generateToken(this.Urls, 200, tokenValue);
cy.get('#swh-token-success-message')
.should('contain', 'Below is your token');
cy.get('#swh-bearer-token')
.should('contain', tokenValue);
}); });
it('should report errors when token generation failed', function() { it('should report error when not logged in and visiting a token generation URL', function() {
initTokensPage(this.Urls, []); cy.visit(this.Urls.oidc_generate_bearer_token_complete(), {failOnStatusCode: false});
generateToken(this.Urls, 400); cy.get('.swh-http-error')
cy.get('#swh-token-error-message') .should('be.visible');
cy.get('.swh-http-error-code')
.should('contain', 403);
cy.get('.swh-http-error-desc')
.should('contain', 'You are not allowed to generate bearer tokens'); .should('contain', 'You are not allowed to generate bearer tokens');
cy.get('#swh-web-modal-html .close').click();
generateToken(this.Urls, 401);
cy.get('#swh-token-error-message')
.should('contain', 'The password is invalid');
cy.get('#swh-web-modal-html .close').click();
generateToken(this.Urls, 500);
cy.get('#swh-token-error-message')
.should('contain', 'Internal server error');
}); });
function displayToken(Urls, status, tokenValue = '') { function displayToken(Urls, status, tokenValue = '') {
cy.route({ cy.route({
method: 'POST', method: 'POST',
url: `${Urls.oidc_get_bearer_token()}/**`, url: `${Urls.oidc_get_bearer_token()}/**`,
response: tokenValue, response: tokenValue,
status: status status: status
}).as('getTokenRequest'); }).as('getTokenRequest');
cy.contains('Display token') cy.contains('Display token')
.click({force: true}); .click({force: true});
cy.get('.modal-dialog') cy.get('.modal-dialog')
.should('be.visible'); .should('be.visible');
cy.get('.modal-header') cy.get('.modal-header')
.should('contain', 'Display bearer token'); .should('contain', 'Display bearer token');
cy.get('#swh-user-password-submit')
.should('be.disabled');
cy.get('#swh-user-password')
.type('secret', {force: true});
cy.get('#swh-user-password-submit')
.should('be.enabled');
cy.get('#swh-user-password-submit')
.click({force: true});
cy.wait('@getTokenRequest');
if (status === 200) {
cy.get('#swh-user-password-submit')
.should('be.disabled');
}
} }
it('should show a token when requested', function() { it('should show a token when requested', function() {
initTokensPage(this.Urls, [{id: 1, creation_date: new Date().toISOString()}]); initTokensPage(this.Urls, [{id: 1, creation_date: new Date().toISOString()}]);
const tokenValue = 'token-value'; const tokenValue = 'token-value';
displayToken(this.Urls, 200, tokenValue); displayToken(this.Urls, 200, tokenValue);
cy.get('#swh-token-success-message')
.should('contain', 'Below is your token');
cy.get('#swh-bearer-token') cy.get('#swh-bearer-token')
.should('contain', tokenValue); .should('contain', tokenValue);
}); });
it('should report errors when token display failed', function() { it('should report errors when token display failed', function() {
initTokensPage(this.Urls, [{id: 1, creation_date: new Date().toISOString()}]); initTokensPage(this.Urls, [{id: 1, creation_date: new Date().toISOString()}]);
displayToken(this.Urls, 401);
cy.get('#swh-token-error-message')
.should('contain', 'The password is invalid');
cy.get('#swh-web-modal-html .close').click();
displayToken(this.Urls, 500); displayToken(this.Urls, 500);
cy.get('#swh-token-error-message') cy.get('.modal-body')
.should('contain', 'Internal server error'); .should('contain', 'Internal server error');
}); });
function revokeToken(Urls, status) { function revokeToken(Urls, status) {
cy.route({ cy.route({
method: 'POST', method: 'POST',
url: `${Urls.oidc_revoke_bearer_tokens()}/**`, url: `${Urls.oidc_revoke_bearer_tokens()}/**`,
response: '', response: '',
status: status status: status
}).as('revokeTokenRequest'); }).as('revokeTokenRequest');
cy.contains('Revoke token') cy.contains('Revoke token')
.click({force: true}); .click({force: true});
cy.get('.modal-dialog') cy.get('.modal-dialog')
.should('be.visible'); .should('be.visible');
cy.get('.modal-header') cy.get('.modal-header')
.should('contain', 'Revoke bearer token'); .should('contain', 'Revoke bearer token');
cy.get('#swh-user-password-submit') cy.get('#swh-token-form-submit')
.should('be.disabled');
cy.get('#swh-user-password')
.type('secret', {force: true});
cy.get('#swh-user-password-submit')
.should('be.enabled');
cy.get('#swh-user-password-submit')
.click({force: true}); .click({force: true});
cy.wait('@revokeTokenRequest'); cy.wait('@revokeTokenRequest');
if (status === 200) { if (status === 200) {
cy.get('#swh-user-password-submit') cy.get('#swh-token-form-submit')
.should('be.disabled'); .should('be.disabled');
} }
} }
it('should revoke a token when requested', function() { it('should revoke a token when requested', function() {
initTokensPage(this.Urls, [{id: 1, creation_date: new Date().toISOString()}]); initTokensPage(this.Urls, [{id: 1, creation_date: new Date().toISOString()}]);
revokeToken(this.Urls, 200); revokeToken(this.Urls, 200);
cy.get('#swh-token-success-message') cy.get('#swh-token-form-message')
.should('contain', 'Bearer token successfully revoked'); .should('contain', 'Bearer token successfully revoked');
}); });
it('should report errors when token revoke failed', function() { it('should report errors when token revoke failed', function() {
initTokensPage(this.Urls, [{id: 1, creation_date: new Date().toISOString()}]); initTokensPage(this.Urls, [{id: 1, creation_date: new Date().toISOString()}]);
revokeToken(this.Urls, 401);
cy.get('#swh-token-error-message')
.should('contain', 'The password is invalid');
cy.get('#swh-web-modal-html .close').click();
revokeToken(this.Urls, 500); revokeToken(this.Urls, 500);
cy.get('#swh-token-error-message') cy.get('#swh-token-error-message')
.should('contain', 'Internal server error'); .should('contain', 'Internal server error');
}); });
}); });
View Options

swh/web/tests/common/test_origin_save.py

Show All 26 Lines cy.route({
} }
}); });
// the tested UI should not be accessible for standard Django users // the tested UI should not be accessible for standard Django users
// but we need a user logged in for testing it // but we need a user logged in for testing it
cy.adminLogin(); cy.adminLogin();
cy.visit(`${Urls.oidc_profile()}#tokens`); cy.visit(`${Urls.oidc_profile()}#tokens`);
} }
function generateToken(Urls, status, tokenValue = '') { it('should initiate token generation flow', function() {
cy.route({ initTokensPage(this.Urls, []);
method: 'POST',
url: `${Urls.oidc_generate_bearer_token()}/**`,
response: tokenValue,
status: status
}).as('generateTokenRequest');
cy.contains('Generate new token') cy.contains('Generate new token')
.click(); .click();
cy.get('.modal-dialog') cy.get('.modal-dialog')
.should('be.visible'); .should('be.visible');
cy.get('.modal-header') cy.get('.modal-header')
.should('contain', 'Bearer token generation'); .should('contain', 'Bearer token generation');
cy.get('#swh-user-password-submit') cy.get('#swh-token-form-submit')
.should('be.disabled');
cy.get('#swh-user-password')
.type('secret');
cy.get('#swh-user-password-submit')
.should('be.enabled');
cy.get('#swh-user-password-submit')
.click(); .click();
cy.wait('@generateTokenRequest'); cy.location().should(loc => {
expect(loc.pathname).to.eq(this.Urls.oidc_generate_bearer_token());
if (status === 200) { });
cy.get('#swh-user-password-submit')
.should('be.disabled');
}
}
it('should generate and display bearer token', function() {
initTokensPage(this.Urls, []);
const tokenValue = 'bearer-token-value';
generateToken(this.Urls, 200, tokenValue);
cy.get('#swh-token-success-message')
.should('contain', 'Below is your token');
cy.get('#swh-bearer-token')
.should('contain', tokenValue);
}); });
it('should report errors when token generation failed', function() { it('should report error when not logged in and visiting a token generation URL', function() {
initTokensPage(this.Urls, []); cy.visit(this.Urls.oidc_generate_bearer_token_complete(), {failOnStatusCode: false});
generateToken(this.Urls, 400); cy.get('.swh-http-error')
cy.get('#swh-token-error-message') .should('be.visible');
cy.get('.swh-http-error-code')
.should('contain', 403);
cy.get('.swh-http-error-desc')
.should('contain', 'You are not allowed to generate bearer tokens'); .should('contain', 'You are not allowed to generate bearer tokens');
cy.get('#swh-web-modal-html .close').click();
generateToken(this.Urls, 401);
cy.get('#swh-token-error-message')
.should('contain', 'The password is invalid');
cy.get('#swh-web-modal-html .close').click();
generateToken(this.Urls, 500);
cy.get('#swh-token-error-message')
.should('contain', 'Internal server error');
}); });
function displayToken(Urls, status, tokenValue = '') { function displayToken(Urls, status, tokenValue = '') {
cy.route({ cy.route({
method: 'POST', method: 'POST',
url: `${Urls.oidc_get_bearer_token()}/**`, url: `${Urls.oidc_get_bearer_token()}/**`,
response: tokenValue, response: tokenValue,
status: status status: status
}).as('getTokenRequest'); }).as('getTokenRequest');
cy.contains('Display token') cy.contains('Display token')
.click({force: true}); .click({force: true});
cy.get('.modal-dialog') cy.get('.modal-dialog')
.should('be.visible'); .should('be.visible');
cy.get('.modal-header') cy.get('.modal-header')
.should('contain', 'Display bearer token'); .should('contain', 'Display bearer token');
cy.get('#swh-user-password-submit')
.should('be.disabled');
cy.get('#swh-user-password')
.type('secret', {force: true});
cy.get('#swh-user-password-submit')
.should('be.enabled');
cy.get('#swh-user-password-submit')
.click({force: true});
cy.wait('@getTokenRequest');
if (status === 200) {
cy.get('#swh-user-password-submit')
.should('be.disabled');
}
} }
it('should show a token when requested', function() { it('should show a token when requested', function() {
initTokensPage(this.Urls, [{id: 1, creation_date: new Date().toISOString()}]); initTokensPage(this.Urls, [{id: 1, creation_date: new Date().toISOString()}]);
const tokenValue = 'token-value'; const tokenValue = 'token-value';
displayToken(this.Urls, 200, tokenValue); displayToken(this.Urls, 200, tokenValue);
cy.get('#swh-token-success-message')
.should('contain', 'Below is your token');
cy.get('#swh-bearer-token') cy.get('#swh-bearer-token')
.should('contain', tokenValue); .should('contain', tokenValue);
}); });
it('should report errors when token display failed', function() { it('should report errors when token display failed', function() {
initTokensPage(this.Urls, [{id: 1, creation_date: new Date().toISOString()}]); initTokensPage(this.Urls, [{id: 1, creation_date: new Date().toISOString()}]);
displayToken(this.Urls, 401);
cy.get('#swh-token-error-message')
.should('contain', 'The password is invalid');
cy.get('#swh-web-modal-html .close').click();
displayToken(this.Urls, 500); displayToken(this.Urls, 500);
cy.get('#swh-token-error-message') cy.get('.modal-body')
.should('contain', 'Internal server error'); .should('contain', 'Internal server error');
}); });
function revokeToken(Urls, status) { function revokeToken(Urls, status) {
cy.route({ cy.route({
method: 'POST', method: 'POST',
url: `${Urls.oidc_revoke_bearer_tokens()}/**`, url: `${Urls.oidc_revoke_bearer_tokens()}/**`,
response: '', response: '',
status: status status: status
}).as('revokeTokenRequest'); }).as('revokeTokenRequest');
cy.contains('Revoke token') cy.contains('Revoke token')
.click({force: true}); .click({force: true});
cy.get('.modal-dialog') cy.get('.modal-dialog')
.should('be.visible'); .should('be.visible');
cy.get('.modal-header') cy.get('.modal-header')
.should('contain', 'Revoke bearer token'); .should('contain', 'Revoke bearer token');
cy.get('#swh-user-password-submit') cy.get('#swh-token-form-submit')
.should('be.disabled');
cy.get('#swh-user-password')
.type('secret', {force: true});
cy.get('#swh-user-password-submit')
.should('be.enabled');
cy.get('#swh-user-password-submit')
.click({force: true}); .click({force: true});
cy.wait('@revokeTokenRequest'); cy.wait('@revokeTokenRequest');
if (status === 200) { if (status === 200) {
cy.get('#swh-user-password-submit') cy.get('#swh-token-form-submit')
.should('be.disabled'); .should('be.disabled');
} }
} }
it('should revoke a token when requested', function() { it('should revoke a token when requested', function() {
initTokensPage(this.Urls, [{id: 1, creation_date: new Date().toISOString()}]); initTokensPage(this.Urls, [{id: 1, creation_date: new Date().toISOString()}]);
revokeToken(this.Urls, 200); revokeToken(this.Urls, 200);
cy.get('#swh-token-success-message') cy.get('#swh-token-form-message')
.should('contain', 'Bearer token successfully revoked'); .should('contain', 'Bearer token successfully revoked');
}); });
it('should report errors when token revoke failed', function() { it('should report errors when token revoke failed', function() {
initTokensPage(this.Urls, [{id: 1, creation_date: new Date().toISOString()}]); initTokensPage(this.Urls, [{id: 1, creation_date: new Date().toISOString()}]);
revokeToken(this.Urls, 401);
cy.get('#swh-token-error-message')
.should('contain', 'The password is invalid');
cy.get('#swh-web-modal-html .close').click();
revokeToken(this.Urls, 500); revokeToken(this.Urls, 500);
cy.get('#swh-token-error-message') cy.get('#swh-token-error-message')
.should('contain', 'Internal server error'); .should('contain', 'Internal server error');
}); });
}); });
About · Developer information · Legal