Paths

Table of Contentst

Differential D4373

common/origin_save: Get more accurate scheduler task termination status
ClosedPublic
Actions

Authored by anlambert on Oct 28 2020, 3:12 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T2658: Failed save code now request reported as succeded

Commits

rDWAPPSd6aeb71affe7: common/origin_save: Get more accurate scheduler task termination status

Summary

Use termination statuses returned by scheduler.get_task_runs to get more
accurate save origin requests reporting regarding their execution states.

Closes T2658

Diff Detail

Repository

rDWAPPS Web applications

Branch

origin-save-improve-task-status-reporting

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 16762
Build 25847: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 25846: arc lint + arc unit

Event Timeline

anlambert created this revision.Oct 28 2020, 3:12 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 28 2020, 3:12 PM

Build is green

Patch application report for D4373 (id=15475)

Rebasing onto 3ffeb396fa...

Current branch diff-target is up to date.

Changes applied before test

commit 8f146d331a6953f572c9d434aae893207d6ca97b
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Oct 28 15:08:33 2020 +0100

    common/origin_save: Get more accurate scheduler task termination status
    
    Use termination statuses returned by scheduler.get_task_runs to get more
    accurate save origin requests reporting regarding their execution states.
    
    Closes T2658

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/441/ for more details.

Harbormaster completed remote builds in B16701: Diff 15475.Oct 28 2020, 3:19 PM

lgtm

Rebase

Build has FAILED

Patch application report for D4373 (id=15536)

Rebasing onto f6cb156178...

Current branch diff-target is up to date.

Changes applied before test

commit a49802a6ad2763c675f712d2fc9829b30bba52af
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Oct 28 15:08:33 2020 +0100

    common/origin_save: Get more accurate scheduler task termination status
    
    Use termination statuses returned by scheduler.get_task_runs to get more
    accurate save origin requests reporting regarding their execution states.
    
    Closes T2658

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/444/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/444/console

Harbormaster failed remote builds in B16762: Diff 15536!Oct 30 2020, 3:40 PM

ardumont accepted this revision.Oct 30 2020, 4:03 PM

This revision is now accepted and ready to land.Oct 30 2020, 4:03 PM

Rebase

Build is green

Patch application report for D4373 (id=15543)

Rebasing onto b51ca62ef3...

Current branch diff-target is up to date.

Changes applied before test

commit d6aeb71affe7c81d7b5d53c8f240eab6cc1a1772
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Oct 28 15:08:33 2020 +0100

    common/origin_save: Get more accurate scheduler task termination status
    
    Use termination statuses returned by scheduler.get_task_runs to get more
    accurate save origin requests reporting regarding their execution states.
    
    Closes T2658

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/446/ for more details.

Harbormaster completed remote builds in B16769: Diff 15543.Oct 30 2020, 4:15 PM

Closed by commit rDWAPPSd6aeb71affe7: common/origin_save: Get more accurate scheduler task termination status (authored by anlambert). · Explain WhyOct 30 2020, 4:22 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPSd6aeb71affe7: common/origin_save: Get more accurate scheduler task termination status.