Differential D4343

api: Skip authentication checks for graph endpoint on swh internal VPN
ClosedPublic
Actions

Authored by anlambert on Oct 23 2020, 1:26 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T2728: Web API: make /graph accessible via the VPN (archive.internal.s.o), even without auth token

Commits

rDWAPPS2e63da424566: api: Skip authentication checks for graph endpoint on swh internal VPN

Summary

Disable authentication checks for graph api endpoint when requests come from
swh internal VPN.

Closes T2728

Diff Detail

Repository

rDWAPPS Web applications

Branch

api-graph-no-auth-on-vpn

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 16597
Build 25582: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 25581: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	4 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.api.views.test_graph::Tests / Python tests / test_graph_endpoint_needs_authentication request = <WSGIRequest: GET '/api/1/graph/stats/'> @wraps(get_response)
	7 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.api.views.test_graph::Tests / Python tests / test_graph_endpoint_no_authentication_for_vpn_users request = <WSGIRequest: GET '/api/1/graph/stats/'> @wraps(get_response)
	216 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.admin.test_origin_save::Tests / Python tests / test_accept_pending_save_request
	864 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.admin.test_origin_save::Tests / Python tests / test_add_authorized_origin_url
	119 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.admin.test_origin_save::Tests / Python tests / test_add_unauthorized_origin_url
		View Full Test Results (2 Failed · 608 Passed · 7 Skipped)

Event Timeline

anlambert created this revision.Oct 23 2020, 1:26 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 23 2020, 1:26 PM

Build has FAILED

Patch application report for D4343 (id=15372)

Rebasing onto e59d91ace1...

Current branch diff-target is up to date.

Changes applied before test

commit 0722d9ba54f17f813d5727c5ad58607f6e280f01
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Oct 23 13:23:21 2020 +0200

    api: Skip authentication checks for graph endpoint on swh internal VPN
    
    Closes T2728

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/431/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/431/console

Harbormaster failed remote builds in B16597: Diff 15372!Oct 23 2020, 1:33 PM

Update: Fix tests

Build is green

Patch application report for D4343 (id=15373)

Rebasing onto e59d91ace1...

Current branch diff-target is up to date.

Changes applied before test

commit 2e63da424566337542854d06019851f9260de9f6
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Oct 23 13:23:21 2020 +0200

    api: Skip authentication checks for graph endpoint on swh internal VPN
    
    Closes T2728

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/432/ for more details.

Harbormaster completed remote builds in B16598: Diff 15373.Oct 23 2020, 1:45 PM

ardumont accepted this revision.Oct 23 2020, 2:20 PM

This revision is now accepted and ready to land.Oct 23 2020, 2:20 PM

Closed by commit rDWAPPS2e63da424566: api: Skip authentication checks for graph endpoint on swh internal VPN (authored by anlambert). · Explain WhyOct 23 2020, 2:23 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS2e63da424566: api: Skip authentication checks for graph endpoint on swh internal VPN.