Page MenuHomeSoftware Heritage

api.server: Add missing coverage on make_app_from_configfile factory
ClosedPublic

Authored by ardumont on Oct 19 2020, 3:07 PM.

Details

Summary

This is actually what starts the server, so it sounds more reasonable to test
that part.

Test Plan

tox

Diff Detail

Repository
rDSTO Storage manager
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16449
Build 25336: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 25335: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D4306 (id=15214)

Could not rebase; Attempt merge onto 49d787c185...

Updating 49d787c1..d93429f8
Fast-forward
 swh/storage/api/server.py        |  8 ++++----
 swh/storage/tests/test_server.py | 40 ++++++++++++++++++++++++++++++++++++++--
 2 files changed, 42 insertions(+), 6 deletions(-)
Changes applied before test
commit d93429f837d30ff1297a427896a11284a07ec2d2
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Oct 19 15:06:36 2020 +0200

    api.server: Add missing coverage on make_app_from_configfile factory
    
    This is actually what starts the server, so it sounds more reasonable to test
    that part.

commit ca8e6aad6d57de5e1c37d9ce02a9e341d9d82533
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Oct 19 15:07:39 2020 +0200

    api.server: Drop the % in the error message

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1011/ for more details.

This revision was not accepted when it landed; it landed in state Needs Review.Oct 21 2020, 1:19 PM
This revision was automatically updated to reflect the committed changes.