Differential D4298

api.tests.test_async: Simplify fixture setup
ClosedPublic
Actions

Authored by ardumont on Oct 19 2020, 9:58 AM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDCORE7f928a07d914: api.tests.test_async: Simplify fixture setup

Summary

No need to repeat the cli instantiation in each asyncio test

Test Plan

tox

Diff Detail

Repository

rDCORE Foundations and core functionalities

Branch

master

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 16421
Build 25290: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 25289: arc lint + arc unit

Event Timeline

ardumont created this revision.Oct 19 2020, 9:58 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 19 2020, 9:58 AM

Build is green

Patch application report for D4298 (id=15186)

Rebasing onto 1657fb827f...

Current branch diff-target is up to date.

Changes applied before test

commit 7f928a07d91460efbbfbc6c5264a4fdd60e58be2
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Sun Oct 18 10:25:01 2020 +0200

    api.tests.test_async: Simplify fixture setup

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/92/ for more details.

Harbormaster completed remote builds in B16421: Diff 15186.Oct 19 2020, 9:59 AM

vlorentz accepted this revision.Oct 19 2020, 12:44 PM

This revision is now accepted and ready to land.Oct 19 2020, 12:44 PM

Closed by commit rDCORE7f928a07d914: api.tests.test_async: Simplify fixture setup (authored by ardumont). · Explain WhyOct 19 2020, 1:19 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDCORE7f928a07d914: api.tests.test_async: Simplify fixture setup.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

swh/

core/

api/

tests/

test_async.py

38 lines

100%

Diff 15186

View Options

swh/core/api/tests/test_async.py

api.tests.test_async: Simplify fixture setupClosedPublicActions