Differential D4267

deposit.loader: Avoid unnecessary metadata json transformation
ClosedPublic
Actions

Authored by ardumont on Oct 15 2020, 11:57 AM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDLDBASEc30e485120f5: deposit.loader: Avoid unnecessary metadata json transformation

Summary

Related to D4233 D4065 D4105

Test Plan

tox

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 16329
Build 25141: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 25140: arc lint + arc unit

Event Timeline

ardumont created this revision.Oct 15 2020, 11:57 AM

Build is green

Patch application report for D4267 (id=15082)

Rebasing onto 0c766379f2...

Current branch diff-target is up to date.

Changes applied before test

commit 4b37c27f686399cab60e0f03e6cde253da1f19ba
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 15 11:35:11 2020 +0200

    deposit.loader: Avoid unnecessary metadata json transformation

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/328/ for more details.

ardumont edited the summary of this revision. (Show Details)Oct 15 2020, 11:59 AM

Harbormaster completed remote builds in B16308: Diff 15082.Oct 15 2020, 11:59 AM

ardumont edited the summary of this revision. (Show Details)Oct 15 2020, 11:59 AM

the commit msg should mention it reverts the change from commit [sha1]

This revision is now accepted and ready to land.Oct 15 2020, 2:33 PM

Rework commit message to explicit the revert part on commit 777ea44

Build is green

Patch application report for D4267 (id=15103)

Rebasing onto 0c766379f2...

Current branch diff-target is up to date.

Changes applied before test

commit c30e485120f570973699017a3e54364ee58f17f8
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 15 11:35:11 2020 +0200

    deposit.loader: Avoid unnecessary metadata json transformation
    
    This reverts a small part of 777ea44 which introduced by mistake that
    conversion into json.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/329/ for more details.

Harbormaster completed remote builds in B16329: Diff 15103.Oct 15 2020, 3:00 PM

Closed by commit rDLDBASEc30e485120f5: deposit.loader: Avoid unnecessary metadata json transformation (authored by ardumont). · Explain WhyOct 15 2020, 3:19 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDLDBASEc30e485120f5: deposit.loader: Avoid unnecessary metadata json transformation.