Differential D4225

test_client: Explicit the possible format outputs
ClosedPublic
Actions

Authored by ardumont on Oct 10 2020, 8:13 AM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDDEP69e527dc239a: test_client: Explicit the possible format outputs

Summary

Related to D4219#inline-28790

Test Plan

tox

Diff Detail

Repository

rDDEP Push deposit

Branch

master

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 16184
Build 24902: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 24901: arc lint + arc unit

Event Timeline

ardumont created this revision.Oct 10 2020, 8:13 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 10 2020, 8:13 AM

ardumont mentioned this in D4219: test_client: Add scenario on deposit status cli.Oct 10 2020, 8:13 AM

Build is green

Patch application report for D4225 (id=14910)

Could not rebase; Attempt merge onto b18cd89d4c...

Updating b18cd89d..2150833f
Fast-forward
 swh/deposit/cli/client.py                          |  27 +-
 swh/deposit/tests/cli/test_client.py               | 441 +++++++++++++++------
 .../https_deposit.test.metadata/1_test_666_media   |   1 +
 .../https_deposit.test.status/1_servicedocument    |  26 ++
 .../https_deposit.test.status/1_test_1033_status   |  10 +
 5 files changed, 369 insertions(+), 136 deletions(-)
 create mode 120000 swh/deposit/tests/data/https_deposit.test.metadata/1_test_666_media
 create mode 100644 swh/deposit/tests/data/https_deposit.test.status/1_servicedocument
 create mode 100644 swh/deposit/tests/data/https_deposit.test.status/1_test_1033_status

Changes applied before test

commit 2150833f440605c5c48b9fef0369f2ccd752f046
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Sat Oct 10 08:13:58 2020 +0200

    test_client: Explicit the possible format outputs

commit 8e99386fa17d22b0ec1eb0fc4a806b233027deca
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 9 16:23:17 2020 +0200

    deposit.client: Improve cli error messages and add missing coverage
    
    This adds the missing checks on:
    - no actionable command
    - missing --deposit-id when specifying the --replace flag
    - some more incompatible checks command scenario

commit 419c1b26d0452bc9965ed01c29ce6c1ab5c50831
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 9 16:10:21 2020 +0200

    test_client: Add a step to update the partial deposit with archive
    
    This should actually cover all the missing cases now.

commit 1a782449064a4228af12ad768862611cc5a49a69
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 9 13:48:49 2020 +0200

    test_client: Add scenario on deposit status cli
    
    This also checks the 3 different format outputs which were not so far.

commit 404f2728ad0f85789b0827025eafb1c8b6124c05
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 9 12:17:58 2020 +0200

    test_client: Refactor and simplify tests for a better readability
    
    This:
    - Align all tests to use json format so the output check is simpler
    - Simplify the failure cases to check the caplog record
    - Drop dead code
    - Rename tests with a `test_cli_` prefix so it's simpler to run separately from
    the rest

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/205/ for more details.

Harbormaster completed remote builds in B16143: Diff 14910.Oct 10 2020, 8:17 AM

you should probably rename the test

This revision is now accepted and ready to land.Oct 12 2020, 3:23 PM

you should probably rename the test

arf, yeah...

(i'm so getting tired of rebasing my diffs..., i'll append that to the top ;)

Rename test method

Build is green

Patch application report for D4225 (id=14955)

Could not rebase; Attempt merge onto 419c1b26d0...

Updating 419c1b26..69e527dc
Fast-forward
 swh/deposit/cli/client.py            |  27 ++--
 swh/deposit/tests/cli/test_client.py | 243 ++++++++++++++++++++++++++---------
 2 files changed, 198 insertions(+), 72 deletions(-)

Changes applied before test

commit 69e527dc239ad9f07d371d124af7b857aba138cc
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Sat Oct 10 08:13:58 2020 +0200

    test_client: Explicit the possible format outputs

commit 8e99386fa17d22b0ec1eb0fc4a806b233027deca
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 9 16:23:17 2020 +0200

    deposit.client: Improve cli error messages and add missing coverage
    
    This adds the missing checks on:
    - no actionable command
    - missing --deposit-id when specifying the --replace flag
    - some more incompatible checks command scenario

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/216/ for more details.

Harbormaster completed remote builds in B16184: Diff 14955.Oct 12 2020, 5:22 PM

Closed by commit rDDEP69e527dc239a: test_client: Explicit the possible format outputs (authored by ardumont). · Explain WhyOct 12 2020, 5:55 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDDEP69e527dc239a: test_client: Explicit the possible format outputs.