Differential D4011

core.config: Decrease configuration loaded path log message to debug
ClosedPublic
Actions

Authored by ardumont on Sep 22 2020, 5:16 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDCOREb5d607989bb2: core.config: Decrease configuration loaded path log-level to debug

Summary

That kind of information is less important than say for example the origin
currently being loaded (which we currently do not have when looking at logs).
Instead, we have plenty of that sample log message everywhere (rpc services,
loader, lister, etc...).

Test Plan

tox

Diff Detail

Repository

rDCORE Foundations and core functionalities

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Sep 22 2020, 5:16 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 22 2020, 5:16 PM

Build is green

Patch application report for D4011 (id=14153)

Rebasing onto bfca0a8d63...

First, rewinding head to replay your work on top of it...
Applying: core.config: Decrease configuration loaded path log-level to debug

Changes applied before test

commit d8882bff856c6ba97b72b068dad430c785a10b1a
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Sep 22 17:14:45 2020 +0200

    core.config: Decrease configuration loaded path log-level to debug

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/80/ for more details.

Harbormaster completed remote builds in B15417: Diff 14153.Sep 22 2020, 5:17 PM

DEBUG log level seems a better choice indeed.

This revision is now accepted and ready to land.Sep 22 2020, 5:18 PM

ardumont mentioned this in D4012: core.loader: Log information about origin currently being ingested.Sep 22 2020, 5:33 PM

Rebase

Build is green

Patch application report for D4011 (id=14155)

Rebasing onto bfca0a8d63...

Current branch diff-target is up to date.

Changes applied before test

commit b5d607989bb2b4d8b9608a33d8e865d1af9f6cac
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Sep 22 17:14:45 2020 +0200

    core.config: Decrease configuration loaded path log-level to debug

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/81/ for more details.

Harbormaster completed remote builds in B15419: Diff 14155.Sep 22 2020, 5:38 PM

Closed by commit rDCOREb5d607989bb2: core.config: Decrease configuration loaded path log-level to debug (authored by ardumont). · Explain WhySep 22 2020, 5:39 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDCOREb5d607989bb2: core.config: Decrease configuration loaded path log-level to debug.