Differential D3920

cli: speedup the `swh` cli command startup time
ClosedPublic
Actions

Authored by douardda on Sep 10 2020, 4:24 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T2575: Investigate if/how we could improve `swh` cli command startup time

Commits

rDSEAc9c58a634a34: cli: speedup the `swh` cli command startup time

Summary

by moving import statements in functions and using conditional
import of typechecking modules (especially swh.storage.interface
which triggers the loading of 300+ modules).

Related to T2575.

Diff Detail

Repository

rDSEA Archive search

Branch

master

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 15035
Build 23170: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 23169: arc lint + arc unit

Event Timeline

douardda created this revision.Sep 10 2020, 4:24 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 10 2020, 4:24 PM

Build is green

Patch application report for D3920 (id=13780)

Rebasing onto 8d6e18d3a3...

Current branch diff-target is up to date.

Changes applied before test

commit b78087700a6f6e04a36c414e1a958277f515a735
Author: David Douard <david.douard@sdfa3.org>
Date:   Thu Sep 10 12:28:01 2020 +0200

    cli: speedup the `swh` cli command startup time
    
    by moving import statements in functions and using conditional
    import of typechecking modules (especially swh.storage.interface
    which triggers the loading of 300+ modules).
    
    Related to T2575.

See https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/37/ for more details.

Harbormaster completed remote builds in B15007: Diff 13780.Sep 10 2020, 4:25 PM

vlorentz added a subscriber: vlorentz.Sep 10 2020, 4:45 PM

vlorentz added inline comments.

swh/search/__init__.py
24–25	strings (see comment in the other diff)

use strin annotations as suggested by vlorent

same *with* the file in the commit --amend

Build is green

Patch application report for D3920 (id=13809)

Rebasing onto 8d6e18d3a3...

Current branch diff-target is up to date.

Changes applied before test

commit 762c453c7055fa290f0bdd8be2fe0945eb49dad0
Author: David Douard <david.douard@sdfa3.org>
Date:   Thu Sep 10 12:28:01 2020 +0200

    cli: speedup the `swh` cli command startup time
    
    by moving import statements in functions and using conditional
    import of typechecking modules (especially swh.storage.interface
    which triggers the loading of 300+ modules).
    
    Related to T2575.

See https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/38/ for more details.

Harbormaster completed remote builds in B15034: Diff 13809.Sep 10 2020, 5:35 PM

Build is green

Patch application report for D3920 (id=13810)

Rebasing onto 8d6e18d3a3...

Current branch diff-target is up to date.

Changes applied before test

commit c9c58a634a341817b2e9ef0015067120358d1b76
Author: David Douard <david.douard@sdfa3.org>
Date:   Thu Sep 10 12:28:01 2020 +0200

    cli: speedup the `swh` cli command startup time
    
    by moving import statements in functions and using conditional
    import of typechecking modules (especially swh.storage.interface
    which triggers the loading of 300+ modules).
    
    Related to T2575.

See https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/39/ for more details.

Harbormaster completed remote builds in B15035: Diff 13810.Sep 10 2020, 5:36 PM

vlorentz accepted this revision.Sep 10 2020, 6:47 PM

This revision is now accepted and ready to land.Sep 10 2020, 6:47 PM

Closed by commit rDSEAc9c58a634a34: cli: speedup the `swh` cli command startup time (authored by douardda). · Explain WhySep 11 2020, 10:32 AM

This revision was automatically updated to reflect the committed changes.

douardda added a commit: rDSEAc9c58a634a34: cli: speedup the `swh` cli command startup time.