Differential D3913

cli: speedup the `swh` cli command startup time
ClosedPublic
Actions

Authored by douardda on Sep 10 2020, 4:14 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T2575: Investigate if/how we could improve `swh` cli command startup time

Commits

rDCIDX2ef7177bc2e2: cli: speedup the `swh` cli command startup time

Summary

by moving import statements in functions.

Related to T2575.

Diff Detail

Repository

rDCIDX Metadata indexer

Branch

master

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 14999
Build 23113: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 23112: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	1,386 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.indexer.tests.test_cli::test_journal_client storage = <swh.storage.in_memory.InMemoryStorage object at 0x7f1d08eba828> indexer_scheduler = <swh.scheduler.backend.SchedulerBackend object at 0x7f1d08de0c88> kafka_prefix = 'cnujhmnpib', kafka_server = '127.0.0.1:37811'
	823 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.indexer.tests.test_cli::test_mapping_list indexer_scheduler = <swh.scheduler.backend.SchedulerBackend object at 0x7f1d0bf99f98> def test_mapping_list(indexer_scheduler):
	351 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.indexer.tests.test_cli::test_mapping_list_terms indexer_scheduler = <swh.scheduler.backend.SchedulerBackend object at 0x7f1d0c385c50> def test_mapping_list_terms(indexer_scheduler):
	351 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.indexer.tests.test_cli::test_mapping_list_terms_exclude indexer_scheduler = <swh.scheduler.backend.SchedulerBackend object at 0x7f1d0c09a1d0> def test_mapping_list_terms_exclude(indexer_scheduler):
	367 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.indexer.tests.test_cli::test_origin_metadata_reindex_divisor indexer_scheduler = <swh.scheduler.backend.SchedulerBackend object at 0x7f1d08e7bb70> idx_storage = <swh.indexer.storage.in_memory.IndexerStorage object at 0x7f1d08e7b668> storage = <swh.storage.in_memory.InMemoryStorage object at 0x7f1d08ea9860>
		View Full Test Results (11 Failed · 308 Passed · 15 Skipped)

Event Timeline

douardda created this revision.Sep 10 2020, 4:14 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 10 2020, 4:14 PM

Build has FAILED

Patch application report for D3913 (id=13772)

Rebasing onto c231873d56...

Current branch diff-target is up to date.

Changes applied before test

commit 939cb934e0794caf1278e3e63c4b013e0045f44d
Author: David Douard <david.douard@sdfa3.org>
Date:   Thu Sep 10 09:26:22 2020 +0200

    cli: speedup the `swh` cli command startup time
    
    by moving import statements in functions.
    
    Related to T2575.

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/49/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/49/console

Harbormaster failed remote builds in B14999: Diff 13772!Sep 10 2020, 4:16 PM

vlorentz accepted this revision.Sep 10 2020, 4:38 PM

This revision is now accepted and ready to land.Sep 10 2020, 4:38 PM

fix test_cli

mock needed being updated

Build is green

Patch application report for D3913 (id=13839)

Rebasing onto c231873d56...

Current branch diff-target is up to date.

Changes applied before test

commit 2ef7177bc2e2916f32171269751485a230828355
Author: David Douard <david.douard@sdfa3.org>
Date:   Thu Sep 10 09:26:22 2020 +0200

    cli: speedup the `swh` cli command startup time
    
    by moving import statements in functions.
    
    Related to T2575.

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/50/ for more details.

Harbormaster completed remote builds in B15064: Diff 13839.Sep 11 2020, 3:09 PM

Closed by commit rDCIDX2ef7177bc2e2: cli: speedup the `swh` cli command startup time (authored by douardda). · Explain WhySep 11 2020, 3:11 PM

This revision was automatically updated to reflect the committed changes.

douardda added a commit: rDCIDX2ef7177bc2e2: cli: speedup the `swh` cli command startup time.