Differential D3853

test_loader: Adapt to latest storage release_get change
ClosedPublic
Actions

Authored by ardumont on Aug 31 2020, 3:49 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T645: Type swh-storage endpoints with swh.model objects

Commits

rDLDHG3baeea1fab5e: test_loader: Adapt to latest storage release_get change

Summary

Related to T645

Test Plan

tox
(failing until release swh.storage > 0.13.2)

Diff Detail

Repository

rDLDHG Mercurial loader

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 14844
Build 22866: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 22865: arc lint + arc unit

Event Timeline

ardumont created this revision.Aug 31 2020, 3:49 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 31 2020, 3:49 PM

Build has FAILED

Patch application report for D3853 (id=13612)

Rebasing onto d11fa9f1d4...

Current branch diff-target is up to date.

Changes applied before test

commit 3baeea1fab5e1e4262b531408e279d1b029c25a6
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Aug 31 15:46:22 2020 +0200

    test_loader: Adapt to latest storage release_get change
    
    Related to T645

Link to build: https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/39/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/39/console

Harbormaster failed remote builds in B14844: Diff 13612!Aug 31 2020, 3:51 PM

ardumont mentioned this in D3852: storage*: release_get(...) -> List[Optional[Release]].Aug 31 2020, 3:53 PM

vlorentz accepted this revision.Aug 31 2020, 4:36 PM

This revision is now accepted and ready to land.Aug 31 2020, 4:36 PM

Build is green

Patch application report for D3853 (id=13612)

Rebasing onto d11fa9f1d4...

Current branch diff-target is up to date.

Changes applied before test

commit 3baeea1fab5e1e4262b531408e279d1b029c25a6
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Aug 31 15:46:22 2020 +0200

    test_loader: Adapt to latest storage release_get change
    
    Related to T645

See https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/40/ for more details.

Harbormaster completed remote builds in B14844: Diff 13612.Sep 1 2020, 2:50 PM

Closed by commit rDLDHG3baeea1fab5e: test_loader: Adapt to latest storage release_get change (authored by ardumont). · Explain WhySep 1 2020, 2:51 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDLDHG3baeea1fab5e: test_loader: Adapt to latest storage release_get change.