Differential D3807

backfiller: Add missing 'extra_header' field.
ClosedPublic
Actions

Authored by vlorentz on Aug 19 2020, 2:56 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDSTOe2f066549123: backfiller: Add missing 'extra_header' field.

Summary

This field wasn't backfilled; and it wasn't caught by tests, because
revisions in swh.journal.tests.journal_data.TEST_OBJECTS were had
an empty extra_header field.

Starting with swh-journal v0.4.3, one of the revisions in TEST_OBJECTS
has a non-empty extra_header field, so it will become a test failure
without this commit

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Aug 19 2020, 2:56 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 19 2020, 2:56 PM

Build is green

Patch application report for D3807 (id=13410)

Rebasing onto bd925475d9...

Current branch diff-target is up to date.

Changes applied before test

commit e2f066549123f069bf0ae34d593038ffd834d9c4
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Aug 19 14:54:45 2020 +0200

    backfiller: Add missing 'extra_header' field.
    
    This field wasn't backfilled; and it wasn't caught by tests, because
    revisions in swh.journal.tests.journal_data.TEST_OBJECTS were had
    an empty extra_header field.
    
    Starting with swh-journal v0.4.3, one of the revisions in TEST_OBJECTS
    has a non-empty extra_header field, so it will become a test failure
    without this commit

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/823/ for more details.

Harbormaster completed remote builds in B14674: Diff 13410.Aug 19 2020, 3:00 PM

anlambert accepted this revision.Aug 19 2020, 3:44 PM

This revision is now accepted and ready to land.Aug 19 2020, 3:44 PM

Closed by commit rDSTOe2f066549123: backfiller: Add missing 'extra_header' field. (authored by vlorentz). · Explain WhyAug 20 2020, 8:51 AM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDSTOe2f066549123: backfiller: Add missing 'extra_header' field..