It helps for code not yet migrated to use model object
Details
Details
- Reviewers
vlorentz - Group Reviewers
Reviewers - Commits
- rDMODd1db7b9954b7: model.Content.to_dict: Remove ctime entry when it's None
tox
Diff Detail
Diff Detail
- Repository
- rDMOD Data model
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 14410 Build 22155: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 22154: arc lint + arc unit
| Time | Test | |
|---|---|---|
| 231 ms | Jenkins > .tox.py3.lib.python3.7.site-packages.swh.model.tests.test_hypothesis_strategies::test_model_to_dicts @given(objects())
> def test_model_to_dicts(obj_type_and_obj):
E hypothesis.errors.MultipleFailures: Hypothesis found 2 distinct failures.
| |
| 3 ms | Jenkins > .tox.py3.lib.python3.7.site-packages.swh.model.merkle::swh.model.merkle.deep_update | |
| 1 ms | Jenkins > .tox.py3.lib.python3.7.site-packages.swh.model.test_identifiers::test_swhid_eq | |
| 1 ms | Jenkins > .tox.py3.lib.python3.7.site-packages.swh.model.test_identifiers::test_swhid_hash | |
| 1 ms | Jenkins > .tox.py3.lib.python3.7.site-packages.swh.model.tests.fields.test_compound.ValidateCompound::test_validate_against_schema | |
| View Full Test Results (1 Failed · 254 Passed · 2 Skipped) |
Event Timeline
Comment Actions
Build has FAILED
Patch application report for D3736 (id=13144)
Rebasing onto 09dcc04a4c...
Current branch diff-target is up to date.
Changes applied before test
commit 3a8a394dc9538ab620266be5074bfcdc3235aeae
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Fri Aug 7 01:41:13 2020 +0200
model.model: Remove ctime entry when it's None
It helps for code not yet migrated to use model objectLink to build: https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/128/
See console output for more information: https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/128/console
Comment Actions
Build is green
Patch application report for D3736 (id=13145)
Rebasing onto 09dcc04a4c...
Current branch diff-target is up to date.
Changes applied before test
commit 360bc923f6e8f5f0ee4750a96bf9f644d82f0352
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Fri Aug 7 01:41:13 2020 +0200
model.Content.to_dict: Remove ctime entry when it's None
Same as for the field data, it helps for code not yet migrated to use model
object.See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/129/ for more details.
| swh/model/tests/test_hypothesis_strategies.py | ||
|---|---|---|
| 132–135 ↗ | (On Diff #13145) | If we are removing None ctime keys for contents, we should do it for skipped_contents too. |
| swh/model/tests/test_hypothesis_strategies.py | ||
|---|---|---|
| 132–135 ↗ | (On Diff #13145) | i was wondering. |
Comment Actions
Build is green
Patch application report for D3736 (id=13150)
Could not rebase; Attempt merge onto 09dcc04a4c...
Updating 09dcc04..d1db7b9 Fast-forward swh/model/model.py | 5 +++++ swh/model/tests/test_hypothesis_strategies.py | 16 ++++++++++------ 2 files changed, 15 insertions(+), 6 deletions(-)
Changes applied before test
commit d1db7b9954b7ec85709dc4037adfdf0bf5be99ad
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Fri Aug 7 01:41:13 2020 +0200
model.Content.to_dict: Remove ctime entry when it's None
Same as for the field data, it helps for code not yet migrated to use model
object.
commit b1a16b168b5803eb855ddafb1b4a6d8cc2ca3bde
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Fri Aug 7 09:46:40 2020 +0200
model: Add Sha1 alias
Related to T645See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/131/ for more details.