Differential D3719

Adapt code according to storage signature
ClosedPublic
Actions

Authored by ardumont on Aug 6 2020, 9:58 AM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T2517: Add remaining missing types to swh.storage.interface

Commits

rDLDHG581c7c8f50db: Adapt code according to storage signature

Summary

Fixes build [1]

[1] https://jenkins.softwareheritage.org/job/DLDHG/job/tests/740/console

Related to T2517

Diff Detail

Repository

rDLDHG Mercurial loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Aug 6 2020, 9:58 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 6 2020, 9:58 AM

Build is green

Patch application report for D3719 (id=13099)

Rebasing onto a272f12351...

Current branch diff-target is up to date.

Changes applied before test

commit 00bf269c18be8f91a9449fcc3659d47bc9adbe7e
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Aug 6 09:58:30 2020 +0200

    Adapt code according to storage type contract
    
    Related to T2517

See https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/37/ for more details.

Harbormaster completed remote builds in B14349: Diff 13099.Aug 6 2020, 9:59 AM

s/type contract/return type/

This revision is now accepted and ready to land.Aug 6 2020, 10:26 AM

ardumont retitled this revision from Adapt code according to storage type contract to Adapt code according to storage signature.Aug 6 2020, 10:26 AM

Rework commit message

Build is green

Patch application report for D3719 (id=13104)

Rebasing onto a272f12351...

Current branch diff-target is up to date.

Changes applied before test

commit 581c7c8f50db93e4de00ddbc5a6c65b00e5ebf2b
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Aug 6 09:58:30 2020 +0200

    Adapt code according to storage signature
    
    Fixes build [1]
    
    [1] https://jenkins.softwareheritage.org/job/DLDHG/job/tests/740/console
    
    Related to T2517

See https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/38/ for more details.

Harbormaster completed remote builds in B14354: Diff 13104.Aug 6 2020, 10:31 AM

Closed by commit rDLDHG581c7c8f50db: Adapt code according to storage signature (authored by ardumont). · Explain WhyAug 6 2020, 10:32 AM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDLDHG581c7c8f50db: Adapt code according to storage signature.