Differential D3716

Adapt code according to storage signature
ClosedPublic
Actions

Authored by ardumont on Aug 6 2020, 9:40 AM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T2517: Add remaining missing types to swh.storage.interface

Commits

rDLDBASEb0dd6219fb77: Adapt code according to storage signature

Summary

This also fixes the build [1]

[1] https://jenkins.softwareheritage.org/job/DLDBASE/job/tests/1028/console

Related to T2517

Test Plan

tox

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 14346
Build 22057: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 22056: arc lint + arc unit

Event Timeline

ardumont created this revision.Aug 6 2020, 9:40 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 6 2020, 9:40 AM

Build is green

Patch application report for D3716 (id=13096)

Rebasing onto 9ee03fb539...

Current branch diff-target is up to date.

Changes applied before test

commit 3e3b6c331fd16e8ad01d7412a89a2f6bfb788fa3
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Aug 6 09:38:20 2020 +0200

    Adapt code according to storage type contract
    
    Related to T2517

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/257/ for more details.

Harbormaster completed remote builds in B14346: Diff 13096.Aug 6 2020, 9:41 AM

s/type contract/signature/

This revision is now accepted and ready to land.Aug 6 2020, 10:25 AM

In D3716#91996, @vlorentz wrote:

s/type contract/signature/

thanks ;)

ardumont retitled this revision from Adapt code according to storage type contract to Adapt code according to storage signature.Aug 6 2020, 10:26 AM

Rework commit message

Build is green

Patch application report for D3716 (id=13101)

Rebasing onto 9ee03fb539...

Current branch diff-target is up to date.

Changes applied before test

commit 1504a4ef328310ab2a269d938120a2b517e29184
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Aug 6 09:38:20 2020 +0200

    Adapt code according to storage signature
    
    Related to T2517

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/258/ for more details.

Harbormaster completed remote builds in B14351: Diff 13101.Aug 6 2020, 10:29 AM

Rework commit message

Build is green

Patch application report for D3716 (id=13103)

Rebasing onto 9ee03fb539...

Current branch diff-target is up to date.

Changes applied before test

commit b0dd6219fb77b49e1a1d5b7070346fdef8904887
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Aug 6 09:38:20 2020 +0200

    Adapt code according to storage signature
    
    This also fixes the build [1]
    
    [1] https://jenkins.softwareheritage.org/job/DLDBASE/job/tests/1028/console
    
    Related to T2517

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/259/ for more details.

Harbormaster completed remote builds in B14353: Diff 13103.Aug 6 2020, 10:31 AM

Closed by commit rDLDBASEb0dd6219fb77: Adapt code according to storage signature (authored by ardumont). · Explain WhyAug 6 2020, 10:31 AM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDLDBASEb0dd6219fb77: Adapt code according to storage signature.