Differential D3709

storage: release_: Type remaining existing endpoints
ClosedPublic
Actions

Authored by ardumont on Aug 5 2020, 12:30 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T2517: Add remaining missing types to swh.storage.interface

Commits

rDSTO7dbd64d9134d: storage*: release_get: Type remaining existing endpoints
rDSTO5f6630a5e48d: storage*: release_missing: Type remaining existing endpoints

Summary

endpoints:

release_missing
release_get

(2 commits)

Related to T2517

Test Plan

tox

Diff Detail

Repository

rDSTO Storage manager

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 14315
Build 22015: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 22014: arc lint + arc unit

Event Timeline

ardumont created this revision.Aug 5 2020, 12:30 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 5 2020, 12:30 PM

Build is green

Patch application report for D3709 (id=13072)

Could not rebase; Attempt merge onto 760cbf6db5...

Updating 760cbf6d..7dbd64d9
Fast-forward
 swh/storage/cassandra/storage.py  | 10 +++++-----
 swh/storage/in_memory.py          | 13 ++++++-------
 swh/storage/interface.py          | 20 ++++++++++----------
 swh/storage/storage.py            | 21 ++++++++++++---------
 swh/storage/tests/test_storage.py |  6 +++---
 5 files changed, 36 insertions(+), 34 deletions(-)

Changes applied before test

commit 7dbd64d9134dee7bc98da89bf90bd1c879d8687c
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Aug 5 12:10:06 2020 +0200

    storage*: release_get: Type remaining existing endpoints
    
    Related to T2517

commit 5f6630a5e48d162c4afcdb65c1293ded4be0cac8
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Aug 5 12:07:15 2020 +0200

    storage*: release_missing: Type remaining existing endpoints
    
    Related to T2517

commit c5d63ada5f51e2b4c493fc7e105fbb776552ccd6
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Aug 5 09:46:37 2020 +0200

    storage*: origin_get_by_sha1: Drop generator from pgstorage
    
    And simplify its type
    
    Related to T645

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/693/ for more details.

Harbormaster completed remote builds in B14315: Diff 13072.Aug 5 2020, 12:34 PM

vlorentz accepted this revision.Aug 5 2020, 12:43 PM

This revision is now accepted and ready to land.Aug 5 2020, 12:43 PM

Closed by commit rDSTO5f6630a5e48d: storage*: release_missing: Type remaining existing endpoints (authored by ardumont). · Explain WhyAug 5 2020, 12:49 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDSTO5f6630a5e48d: storage*: release_missing: Type remaining existing endpoints.

ardumont added a commit: rDSTO7dbd64d9134d: storage*: release_get: Type remaining existing endpoints.